Skip to content

Updated error message to include user info #130444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Aaina26
Copy link
Contributor

@Aaina26 Aaina26 commented Feb 26, 2025

Fixes #130275

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Aaina26. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Aaina26
Once this PR has been reviewed and has the lgtm label, please assign jpbetz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Aaina26
Copy link
Contributor Author

Aaina26 commented Feb 27, 2025

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 27, 2025
@siyuanfoundation
Copy link
Contributor

/lgtm
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 27, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6f803f9d66104a5242a724c2beba3805b4cc6536

@Aaina26
Copy link
Contributor Author

Aaina26 commented Mar 1, 2025

pull-kubernetes-unit failed due to my changes which I have corrected.
But before I commit those changes, I want to confirm following for pull-kubernetes-linter-hints failure:

  • It suggests usage of %w instead of %v to wrap an error in fmt.Errorf. But this is not related to my change. It would require changing third %v placeholder to %w. If it is okay to do so, I can make the change and add it to my commit so that this test passes

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 4, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@Aaina26
Copy link
Contributor Author

Aaina26 commented Mar 4, 2025

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 4, 2025
@Aaina26
Copy link
Contributor Author

Aaina26 commented Mar 4, 2025

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 4, 2025
@Aaina26
Copy link
Contributor Author

Aaina26 commented Mar 10, 2025

Hi @siyuanfoundation! I fixed the tests. Please take a look.

@dims
Copy link
Member

dims commented Mar 17, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 17, 2025
@benjaminapetersen
Copy link
Member

@jpbetz @deads2k for review.

@Aaina26
Copy link
Contributor Author

Aaina26 commented Mar 17, 2025

I have changed the placeholder to "%w" where error was being wrapped. Although,I checked with my previous commit and the test had passed in my local but not when I committed. I am curious to know why that happened.

./hack/verify-golangci-lint.sh
installing golangci-lint and logcheck plugin from hack/tools into /home/necuser/k8_project/kubernetes/_output/local/bin
running /home/necuser/k8_project/kubernetes/_output/local/bin/golangci-lint run --color=always --config=/home/necuser/k8_project/kubernetes/hack/golangci.yaml ./... ./staging/src/k8s.io/api/... ./staging/src/k8s.io/apiextensions-apiserver/... ./staging/src/k8s.io/apimachinery/... ./staging/src/k8s.io/apiserver/... ./staging/src/k8s.io/cli-runtime/... ./staging/src/k8s.io/client-go/... ./staging/src/k8s.io/cloud-provider/... ./staging/src/k8s.io/cluster-bootstrap/... ./staging/src/k8s.io/code-generator/... ./staging/src/k8s.io/component-base/... ./staging/src/k8s.io/component-helpers/... ./staging/src/k8s.io/controller-manager/... ./staging/src/k8s.io/cri-api/... ./staging/src/k8s.io/cri-client/... ./staging/src/k8s.io/csi-translation-lib/... ./staging/src/k8s.io/dynamic-resource-allocation/... ./staging/src/k8s.io/endpointslice/... ./staging/src/k8s.io/externaljwt/... ./staging/src/k8s.io/kms/... ./staging/src/k8s.io/kube-aggregator/... ./staging/src/k8s.io/kube-controller-manager/... ./staging/src/k8s.io/kube-proxy/... ./staging/src/k8s.io/kube-scheduler/... ./staging/src/k8s.io/kubectl/... ./staging/src/k8s.io/kubelet/... ./staging/src/k8s.io/metrics/... ./staging/src/k8s.io/mount-utils/... ./staging/src/k8s.io/pod-security-admission/... ./staging/src/k8s.io/sample-apiserver/... ./staging/src/k8s.io/sample-cli-plugin/... ./staging/src/k8s.io/sample-controller/...
Congratulations! All files are passing lint :-)

@Aaina26
Copy link
Contributor Author

Aaina26 commented Mar 24, 2025

Hi @jpbetz @siyuanfoundation @deads2k ,
Could you please take a look, so that this PR will be merged?

Thanks!

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error messages make debugging unnecessarily complex
6 participants