[KEP-2400] [failing-test] resource metrics e2e tests: expect swap node and container level stats #130053

iholder101 · 2025-02-09T15:55:37Z

/kind failing-test

What type of PR is this?

What this PR does / why we need it:

Fixing failing test reported by #129991 by expecting swap node and container level stats.

Which issue(s) this PR fixes:

Fixes #129991

Testgrid link:
https://testgrid.k8s.io/sig-node-presubmits#pr-crio-cgrpv1-evented-pleg-gce-e2e-kubetest2

Failure:

Expected
    <string>: KubeletMetrics
to match keys: {
."node_swap_usage_bytes":
	unexpected key node_swap_usage_bytes: map[container_cpu_usage_seconds_total:[container_cpu_usage_seconds_total{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-0"} => 0.191321 @[1738767713.808] container_cpu_usage_seconds_total{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-1"} => 0.169314 @[1738767705.332] container_cpu_usage_seconds_total{container="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e", namespace="kubelet-test-5805", pod="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e"} => 0.015503 @[1738767710.62] container_cpu_usage_seconds_total{container="main", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 0.052462 @[1738767703.24] container_cpu_usage_seconds_total{container="regular-1", namespace="containers-lifecycle-test-5036", pod="restartable-init-container-exit-0-continuously"} => 0.050144 @[1738767715.33] container_cpu_usage_seconds_total{container="restartable-init-2", namespace="containers-lifecycle-test-5059", pod="restartable-init-container-failed-liveness-imgupdate-always"} => 0.035203 @[1738767716.439] container_cpu_usage_seconds_total{container="sidecar", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 0.055067 @[1738767700.405] container_cpu_usage_seconds_total{container="sidecar", namespace="container-probe-9632", pod="startup-sidecar-eeba75db-141e-4f6a-be8d-71979e843558"} => 0.016363 @[1738767712.248]] container_memory_working_set_bytes:[container_memory_working_set_bytes{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-0"} => 352256 @[1738767713.808] container_memory_working_set_bytes{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-1"} => 356352 @[1738767705.332] container_memory_working_set_bytes{container="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e", namespace="kubelet-test-5805", pod="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e"} => 352256 @[1738767710.62] container_memory_working_set_bytes{container="main", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 5931008 @[1738767703.24] container_memory_working_set_bytes{container="regular-1", namespace="containers-lifecycle-test-5036", pod="restartable-init-container-exit-0-continuously"} => 581632 @[1738767715.33] container_memory_working_set_bytes{container="restartable-init-2", namespace="containers-lifecycle-test-5059", pod="restartable-init-container-failed-liveness-imgupdate-always"} => 413696 @[1738767716.439] container_memory_working_set_bytes{container="sidecar", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 5951488 @[1738767700.405] container_memory_working_set_bytes{container="sidecar", namespace="container-probe-9632", pod="startup-sidecar-eeba75db-141e-4f6a-be8d-71979e843558"} => 339968 @[1738767712.248]] container_start_time_seconds:[container_start_time_seconds{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-0"} => 1738767647.58987 @[0] container_start_time_seconds{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-1"} => 1738767650.09542 @[0] container_start_time_seconds{container="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e", namespace="kubelet-test-5805", pod="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e"} => 1738767686.2433274 @[0] container_start_time_seconds{container="main", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 1738767590.153934 @[0] container_start_time_seconds{container="regular-1", namespace="containers-lifecycle-test-5036", pod="restartable-init-container-exit-0-continuously"} => 1738767685.4388096 @[0] container_start_time_seconds{container="restartable-init-2", namespace="containers-lifecycle-test-5059", pod="restartable-init-container-failed-liveness-imgupdate-always"} => 1738767705.1093965 @[0] container_start_time_seconds{container="sidecar", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 1738767586.9450195 @[0] container_start_time_seconds{container="sidecar", namespace="container-probe-9632", pod="startup-sidecar-eeba75db-141e-4f6a-be8d-71979e843558"} => 1738767701.5413375 @[0]] container_swap_usage_bytes:[container_swap_usage_bytes{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-0"} => 0 @[1738767713.808] container_swap_usage_bytes{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-1"} => 0 @[1738767705.332] container_swap_usage_bytes{container="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e", namespace="kubelet-test-5805", pod="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e"} => 0 @[1738767710.62] container_swap_usage_bytes{container="main", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 0 @[1738767703.24] container_swap_usage_bytes{container="regular-1", namespace="containers-lifecycle-test-5036", pod="restartable-init-container-exit-0-continuously"} => 0 @[1738767715.33] container_swap_usage_bytes{container="restartable-init-2", namespace="containers-lifecycle-test-5059", pod="restartable-init-container-failed-liveness-imgupdate-always"} => 0 @[1738767716.439] container_swap_usage_bytes{container="sidecar", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 0 @[1738767700.405] container_swap_usage_bytes{container="sidecar", namespace="container-probe-9632", pod="startup-sidecar-eeba75db-141e-4f6a-be8d-71979e843558"} => 0 @[1738767712.248]] node_cpu_usage_seconds_total:[node_cpu_usage_seconds_total => 531.060042 @[1738767712.185]] node_memory_working_set_bytes:[node_memory_working_set_bytes => 1450782720 @[1738767712.185]] node_swap_usage_bytes:[node_swap_usage_bytes => 0 @[1738767712.185]] pod_cpu_usage_seconds_total:[pod_cpu_usage_seconds_total{namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 0.151997 @[1738767702.892] pod_cpu_usage_seconds_total{namespace="container-probe-7953", pod="busybox-119854c3-757e-44c1-b3aa-2ed63d7d145d"} => 0.069656 @[1738767713.706] pod_cpu_usage_seconds_total{namespace="container-probe-9632", pod="startup-sidecar-eeba75db-141e-4f6a-be8d-71979e843558"} => 0 @[1738767701.16] pod_cpu_usage_seconds_total{namespace="containers-lifecycle-test-5036", pod="restartable-init-container-exit-0-continuously"} => 0.293861 @[1738767708.367] pod_cpu_usage_seconds_total{namespace="containers-lifecycle-test-5059", pod="restartable-init-container-failed-liveness-imgupdate-always"} => 0 @[1738767702.273] pod_cpu_usage_seconds_total{namespace="kubelet-test-5805", pod="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e"} => 0.061539 @[1738767709.597] pod_cpu_usage_seconds_total{namespace="resource-metrics-5450", pod="stats-busybox-0"} => 0.275492 @[1738767715.552] pod_cpu_usage_seconds_total{namespace="resource-metrics-5450", pod="stats-busybox-1"} => 0.242798 @[1738767704.087]] pod_memory_working_set_bytes:[pod_memory_working_set_bytes{namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 12107776 @[1738767702.892] pod_memory_working_set_bytes{namespace="container-probe-7953", pod="busybox-119854c3-757e-44c1-b3aa-2ed63d7d145d"} => 557056 @[1738767713.706] pod_memory_working_set_bytes{namespace="container-probe-9632", pod="startup-sidecar-eeba75db-141e-4f6a-be8d-71979e843558"} => 0 @[1738767701.16] pod_memory_working_set_bytes{namespace="containers-lifecycle-test-5036", pod="restartable-init-container-exit-0-continuously"} => 921600 @[1738767708.367] pod_memory_working_set_bytes{namespace="containers-lifecycle-test-5059", pod="restartable-init-container-failed-liveness-imgupdate-always"} => 0 @[1738767702.273] pod_memory_working_set_bytes{namespace="kubelet-test-5805", pod="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e"} => 577536 @[1738767709.597] pod_memory_working_set_bytes{namespace="resource-metrics-5450", pod="stats-busybox-0"} => 610304 @[1738767715.552] pod_memory_working_set_bytes{namespace="resource-metrics-5450", pod="stats-busybox-1"} => 618496 @[1738767704.087]] pod_swap_usage_bytes:[pod_swap_usage_bytes{namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 0 @[1738767702.892] pod_swap_usage_bytes{namespace="container-probe-7953", pod="busybox-119854c3-757e-44c1-b3aa-2ed63d7d145d"} => 0 @[1738767713.706] pod_swap_usage_bytes{namespace="container-probe-9632", pod="startup-sidecar-eeba75db-141e-4f6a-be8d-71979e843558"} => 0 @[1738767701.16] pod_swap_usage_bytes{namespace="containers-lifecycle-test-5036", pod="restartable-init-container-exit-0-continuously"} => 0 @[1738767708.367] pod_swap_usage_bytes{namespace="containers-lifecycle-test-5059", pod="restartable-init-container-failed-liveness-imgupdate-always"} => 0 @[1738767702.273] pod_swap_usage_bytes{namespace="kubelet-test-5805", pod="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e"} => 0 @[1738767709.597] pod_swap_usage_bytes{namespace="resource-metrics-5450", pod="stats-busybox-0"} => 0 @[1738767715.552] pod_swap_usage_bytes{namespace="resource-metrics-5450", pod="stats-busybox-1"} => 0 @[1738767704.087]] resource_scrape_error:[resource_scrape_error => 0 @[0]]]
."container_swap_usage_bytes":
	unexpected key container_swap_usage_bytes: map[container_cpu_usage_seconds_total:[container_cpu_usage_seconds_total{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-0"} => 0.191321 @[1738767713.808] container_cpu_usage_seconds_total{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-1"} => 0.169314 @[1738767705.332] container_cpu_usage_seconds_total{container="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e", namespace="kubelet-test-5805", pod="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e"} => 0.015503 @[1738767710.62] container_cpu_usage_seconds_total{container="main", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 0.052462 @[1738767703.24] container_cpu_usage_seconds_total{container="regular-1", namespace="containers-lifecycle-test-5036", pod="restartable-init-container-exit-0-continuously"} => 0.050144 @[1738767715.33] container_cpu_usage_seconds_total{container="restartable-init-2", namespace="containers-lifecycle-test-5059", pod="restartable-init-container-failed-liveness-imgupdate-always"} => 0.035203 @[1738767716.439] container_cpu_usage_seconds_total{container="sidecar", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 0.055067 @[1738767700.405] container_cpu_usage_seconds_total{container="sidecar", namespace="container-probe-9632", pod="startup-sidecar-eeba75db-141e-4f6a-be8d-71979e843558"} => 0.016363 @[1738767712.248]] container_memory_working_set_bytes:[container_memory_working_set_bytes{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-0"} => 352256 @[1738767713.808] container_memory_working_set_bytes{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-1"} => 356352 @[1738767705.332] container_memory_working_set_bytes{container="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e", namespace="kubelet-test-5805", pod="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e"} => 352256 @[1738767710.62] container_memory_working_set_bytes{container="main", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 5931008 @[1738767703.24] container_memory_working_set_bytes{container="regular-1", namespace="containers-lifecycle-test-5036", pod="restartable-init-container-exit-0-continuously"} => 581632 @[1738767715.33] container_memory_working_set_bytes{container="restartable-init-2", namespace="containers-lifecycle-test-5059", pod="restartable-init-container-failed-liveness-imgupdate-always"} => 413696 @[1738767716.439] container_memory_working_set_bytes{container="sidecar", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 5951488 @[1738767700.405] container_memory_working_set_bytes{container="sidecar", namespace="container-probe-9632", pod="startup-sidecar-eeba75db-141e-4f6a-be8d-71979e843558"} => 339968 @[1738767712.248]] container_start_time_seconds:[container_start_time_seconds{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-0"} => 1738767647.58987 @[0] container_start_time_seconds{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-1"} => 1738767650.09542 @[0] container_start_time_seconds{container="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e", namespace="kubelet-test-5805", pod="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e"} => 1738767686.2433274 @[0] container_start_time_seconds{container="main", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 1738767590.153934 @[0] container_start_time_seconds{container="regular-1", namespace="containers-lifecycle-test-5036", pod="restartable-init-container-exit-0-continuously"} => 1738767685.4388096 @[0] container_start_time_seconds{container="restartable-init-2", namespace="containers-lifecycle-test-5059", pod="restartable-init-container-failed-liveness-imgupdate-always"} => 1738767705.1093965 @[0] container_start_time_seconds{container="sidecar", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 1738767586.9450195 @[0] container_start_time_seconds{container="sidecar", namespace="container-probe-9632", pod="startup-sidecar-eeba75db-141e-4f6a-be8d-71979e843558"} => 1738767701.5413375 @[0]] container_swap_usage_bytes:[container_swap_usage_bytes{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-0"} => 0 @[1738767713.808] container_swap_usage_bytes{container="busybox-container", namespace="resource-metrics-5450", pod="stats-busybox-1"} => 0 @[1738767705.332] container_swap_usage_bytes{container="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e", namespace="kubelet-test-5805", pod="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e"} => 0 @[1738767710.62] container_swap_usage_bytes{container="main", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 0 @[1738767703.24] container_swap_usage_bytes{container="regular-1", namespace="containers-lifecycle-test-5036", pod="restartable-init-container-exit-0-continuously"} => 0 @[1738767715.33] container_swap_usage_bytes{container="restartable-init-2", namespace="containers-lifecycle-test-5059", pod="restartable-init-container-failed-liveness-imgupdate-always"} => 0 @[1738767716.439] container_swap_usage_bytes{container="sidecar", namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 0 @[1738767700.405] container_swap_usage_bytes{container="sidecar", namespace="container-probe-9632", pod="startup-sidecar-eeba75db-141e-4f6a-be8d-71979e843558"} => 0 @[1738767712.248]] node_cpu_usage_seconds_total:[node_cpu_usage_seconds_total => 531.060042 @[1738767712.185]] node_memory_working_set_bytes:[node_memory_working_set_bytes => 1450782720 @[1738767712.185]] node_swap_usage_bytes:[node_swap_usage_bytes => 0 @[1738767712.185]] pod_cpu_usage_seconds_total:[pod_cpu_usage_seconds_total{namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 0.151997 @[1738767702.892] pod_cpu_usage_seconds_total{namespace="container-probe-7953", pod="busybox-119854c3-757e-44c1-b3aa-2ed63d7d145d"} => 0.069656 @[1738767713.706] pod_cpu_usage_seconds_total{namespace="container-probe-9632", pod="startup-sidecar-eeba75db-141e-4f6a-be8d-71979e843558"} => 0 @[1738767701.16] pod_cpu_usage_seconds_total{namespace="containers-lifecycle-test-5036", pod="restartable-init-container-exit-0-continuously"} => 0.293861 @[1738767708.367] pod_cpu_usage_seconds_total{namespace="containers-lifecycle-test-5059", pod="restartable-init-container-failed-liveness-imgupdate-always"} => 0 @[1738767702.273] pod_cpu_usage_seconds_total{namespace="kubelet-test-5805", pod="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e"} => 0.061539 @[1738767709.597] pod_cpu_usage_seconds_total{namespace="resource-metrics-5450", pod="stats-busybox-0"} => 0.275492 @[1738767715.552] pod_cpu_usage_seconds_total{namespace="resource-metrics-5450", pod="stats-busybox-1"} => 0.242798 @[1738767704.087]] pod_memory_working_set_bytes:[pod_memory_working_set_bytes{namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 12107776 @[1738767702.892] pod_memory_working_set_bytes{namespace="container-probe-7953", pod="busybox-119854c3-757e-44c1-b3aa-2ed63d7d145d"} => 557056 @[1738767713.706] pod_memory_working_set_bytes{namespace="container-probe-9632", pod="startup-sidecar-eeba75db-141e-4f6a-be8d-71979e843558"} => 0 @[1738767701.16] pod_memory_working_set_bytes{namespace="containers-lifecycle-test-5036", pod="restartable-init-container-exit-0-continuously"} => 921600 @[1738767708.367] pod_memory_working_set_bytes{namespace="containers-lifecycle-test-5059", pod="restartable-init-container-failed-liveness-imgupdate-always"} => 0 @[1738767702.273] pod_memory_working_set_bytes{namespace="kubelet-test-5805", pod="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e"} => 577536 @[1738767709.597] pod_memory_working_set_bytes{namespace="resource-metrics-5450", pod="stats-busybox-0"} => 610304 @[1738767715.552] pod_memory_working_set_bytes{namespace="resource-metrics-5450", pod="stats-busybox-1"} => 618496 @[1738767704.087]] pod_swap_usage_bytes:[pod_swap_usage_bytes{namespace="container-probe-2990", pod="test-liveness-sidecar-8f2e7533-5e29-4058-878e-9fd43d8a3b13"} => 0 @[1738767702.892] pod_swap_usage_bytes{namespace="container-probe-7953", pod="busybox-119854c3-757e-44c1-b3aa-2ed63d7d145d"} => 0 @[1738767713.706] pod_swap_usage_bytes{namespace="container-probe-9632", pod="startup-sidecar-eeba75db-141e-4f6a-be8d-71979e843558"} => 0 @[1738767701.16] pod_swap_usage_bytes{namespace="containers-lifecycle-test-5036", pod="restartable-init-container-exit-0-continuously"} => 0 @[1738767708.367] pod_swap_usage_bytes{namespace="containers-lifecycle-test-5059", pod="restartable-init-container-failed-liveness-imgupdate-always"} => 0 @[1738767702.273] pod_swap_usage_bytes{namespace="kubelet-test-5805", pod="busybox-scheduling-a43f2c17-bd84-4648-b51c-fa6a77ebb10e"} => 0 @[1738767709.597] pod_swap_usage_bytes{namespace="resource-metrics-5450", pod="stats-busybox-0"} => 0 @[1738767715.552] pod_swap_usage_bytes{namespace="resource-metrics-5450", pod="stats-busybox-1"} => 0 @[1738767704.087]] resource_scrape_error:[resource_scrape_error => 0 @[0]]]

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2400-node-swap/README.md

k8s-ci-robot · 2025-02-09T15:55:39Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

iholder101 · 2025-02-09T15:56:38Z

/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e-kubetest2
/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e

iholder101 · 2025-02-09T16:02:24Z

/test all

ffromani · 2025-02-09T19:10:13Z

/triage accepted
/priority important-soon
/cc

kannon92 · 2025-02-10T17:35:13Z

/assign @SergeyKanzhelev

test/e2e_node/resource_metrics_test.go

kannon92 · 2025-02-10T17:37:50Z

/lgtm cancel

Sorry, I think https://github.com/kubernetes/kubernetes/pull/130053/files#r1949598028 we should address. Swap is not enabled in some of these tests so I don't think we should expect a wide range of values for those.

Signed-off-by: Itamar Holder <[email protected]>

iholder101 · 2025-02-11T13:21:24Z

/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e-kubetest2
/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e
/test pull-kubernetes-node-e2e-containerd-features

iholder101 · 2025-02-11T13:41:43Z

/test pull-kubernetes-node-swap-ubuntu-serial
/test pull-kubernetes-node-swap-fedora
/test pull-kubernetes-node-swap-fedora-serial

iholder101 · 2025-02-11T14:06:52Z

/test pull-kubernetes-node-e2e-containerd-features

iholder101 · 2025-02-11T16:17:09Z

Ran 147 of 734 Specs in 779.207 seconds
SUCCESS! -- 147 Passed | 0 Failed | 0 Pending | 587 Skipped

@kannon92 the features lane failures do not seem relevant. Can you have a look?

kannon92 · 2025-02-11T16:20:42Z

/lgtm

/assign @mrunalp @SergeyKanzhelev

k8s-ci-robot · 2025-02-11T16:20:48Z

LGTM label has been added.

Git tree hash: 975386cd141837cf4cd44160509ae80f6a77b50c

SergeyKanzhelev

/lgtm
/approve

SergeyKanzhelev · 2025-02-12T18:28:37Z

/retest

k8s-ci-robot · 2025-02-12T18:28:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iholder101, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~test/e2e_node/OWNERS~~ [SergeyKanzhelev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-02-12T19:12:40Z

@iholder101: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e-kubetest2	`8a797e4`	link	false	`/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e-kubetest2`
pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e	`8a797e4`	link	false	`/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

iholder101 force-pushed the bugfix/swap-resource-metrics-e2e-bug branch from 0ed8cfd to d114c9d Compare February 9, 2025 15:55

k8s-ci-robot requested review from ffromani and odinuge February 9, 2025 15:55

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 9, 2025

iholder101 marked this pull request as ready for review February 9, 2025 17:33

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2025

k8s-ci-robot requested review from andrewsykim and feiskyer February 9, 2025 17:34

iholder101 mentioned this pull request Feb 9, 2025

Revert "Merge pull request #129486 from iholder101/bugfix/swap-container-cri-stats" #130031

Closed

iholder101 changed the title ~~[KEP-2400] [Bugfix] resource metrics e2e tests: expect swap node and container level stats~~ [KEP-2400] [failing-test] resource metrics e2e tests: expect swap node and container level stats Feb 9, 2025

k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Feb 9, 2025

k8s-ci-robot assigned SergeyKanzhelev Feb 10, 2025

kannon92 reviewed Feb 10, 2025

View reviewed changes

test/e2e_node/resource_metrics_test.go Show resolved Hide resolved

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2025

k8s-ci-robot requested review from kannon92, mrunalp and SergeyKanzhelev February 10, 2025 17:37

iholder101 force-pushed the bugfix/swap-resource-metrics-e2e-bug branch from d114c9d to 28394e0 Compare February 11, 2025 13:19

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2025

resource metrics e2e tests: expect swap node and container level stats

8a797e4

Signed-off-by: Itamar Holder <[email protected]>

iholder101 force-pushed the bugfix/swap-resource-metrics-e2e-bug branch from 28394e0 to 8a797e4 Compare February 11, 2025 13:19

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2025

austinvazquez mentioned this pull request Feb 12, 2025

[release/1.7] Fix console TTY leak in runc shim containerd/containerd#11250

Merged

SergeyKanzhelev approved these changes Feb 12, 2025

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025

k8s-ci-robot merged commit 5e1c31b into kubernetes:master Feb 12, 2025
17 of 19 checks passed

k8s-ci-robot added this to the v1.33 milestone Feb 12, 2025

HirazawaUi mentioned this pull request Feb 13, 2025

[evented pleg]: using real-time container events for pod state determination #129355

Open

pacoxu mentioned this pull request Feb 24, 2025

Node memory swap support kubernetes/enhancements#2400

Open

69 tasks

[KEP-2400] [failing-test] resource metrics e2e tests: expect swap node and container level stats #130053

[KEP-2400] [failing-test] resource metrics e2e tests: expect swap node and container level stats #130053

Uh oh!

Conversation

iholder101 commented Feb 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Feb 9, 2025

Uh oh!

iholder101 commented Feb 9, 2025

Uh oh!

iholder101 commented Feb 9, 2025

Uh oh!

ffromani commented Feb 9, 2025

Uh oh!

kannon92 commented Feb 10, 2025

Uh oh!

Uh oh!

kannon92 commented Feb 10, 2025

Uh oh!

iholder101 commented Feb 11, 2025

Uh oh!

iholder101 commented Feb 11, 2025

Uh oh!

iholder101 commented Feb 11, 2025

Uh oh!

iholder101 commented Feb 11, 2025

Uh oh!

kannon92 commented Feb 11, 2025

Uh oh!

k8s-ci-robot commented Feb 11, 2025

Uh oh!

SergeyKanzhelev left a comment

Choose a reason for hiding this comment

Uh oh!

SergeyKanzhelev commented Feb 12, 2025

Uh oh!

k8s-ci-robot commented Feb 12, 2025

Uh oh!

k8s-ci-robot commented Feb 12, 2025

Uh oh!

Uh oh!

Uh oh!

iholder101 commented Feb 9, 2025 •

edited

Loading