-
Notifications
You must be signed in to change notification settings - Fork 40.9k
[KEP-2400] [failing-test] resource metrics e2e tests: expect swap node and container level stats #130053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KEP-2400] [failing-test] resource metrics e2e tests: expect swap node and container level stats #130053
Conversation
Skipping CI for Draft Pull Request. |
0ed8cfd
to
d114c9d
Compare
/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e-kubetest2 |
/test all |
/triage accepted |
/assign @SergeyKanzhelev |
/lgtm cancel Sorry, I think https://github.com/kubernetes/kubernetes/pull/130053/files#r1949598028 we should address. Swap is not enabled in some of these tests so I don't think we should expect a wide range of values for those. |
d114c9d
to
28394e0
Compare
Signed-off-by: Itamar Holder <[email protected]>
28394e0
to
8a797e4
Compare
/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e-kubetest2 |
/test pull-kubernetes-node-swap-ubuntu-serial |
/test pull-kubernetes-node-e2e-containerd-features |
/lgtm /assign @mrunalp @SergeyKanzhelev |
LGTM label has been added. Git tree hash: 975386cd141837cf4cd44160509ae80f6a77b50c
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iholder101, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@iholder101: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/kind failing-test
What type of PR is this?
What this PR does / why we need it:
Fixing failing test reported by #129991 by expecting swap node and container level stats.
Which issue(s) this PR fixes:
Fixes #129991
Testgrid link:
https://testgrid.k8s.io/sig-node-presubmits#pr-crio-cgrpv1-evented-pleg-gce-e2e-kubetest2
Failure:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: