e2e apps: remove unnecessary feature labels #129154

carlory · 2024-12-11T03:59:32Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

feature.PodIndexLabel will be GA in 1.32.
feature.StatefulSet is a stable feature. It‘s safe to remove it because tests will be skipped if the cluster have no default sc.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2024-12-11T03:59:35Z

Please note that we're already in Test Freeze for the release-1.32 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.32.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Dec 11 00:11:49 UTC 2024.

k8s-ci-robot · 2024-12-11T03:59:41Z

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kannon92 · 2024-12-12T14:48:05Z

test/e2e/apps/job.go

@@ -446,7 +445,7 @@ done`}
 	*/
 	// TODO: once this test is stable, squash the functionality into pre-existing conformance test called "should create


cc @alaypatel07

this is GA in 1.32, so it should not be feature gated, if the test fails we have a problem

kannon92 · 2024-12-12T15:03:15Z

I'd like confirmation that we have presubmits that are triggering these tests before merge.

/hold

kannon92 · 2024-12-12T15:03:51Z

IMO I would maybe considering moving these tests to conformance if they are not long running and don't require special environments.

carlory · 2024-12-13T02:48:15Z

According to the comments in these tests, it wouldn't be marked as Conformance because StatefulSet Conformance should not be dependent on specific applications.

There is a dedicated job for testing these clustered applications which is labeled as [StatefulSet]. the job is ci-kubernetes-e2e-gci-gce-statefulset.

If the feature label StatefulSet were removed, the job ci-kubernetes-e2e-gci-gce-statefulset might be removed as well. the job ci-kubernetes-e2e-gci-gce-slow will be responsible for testing these clustered applications and report the results to the gce-slow dashboard for sig-apps. @kannon92

I'm not sure whether it is ok to promote PodIndexLabel e2e tests to Conformance at this time. The feature-gate isn't removed yet.

carlory · 2024-12-13T02:52:33Z

I'd like confirmation that we have presubmits that are triggering these tests before merge.我想确认我们有在合并之前触发这些测试的预提交。

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/129154/pull-kubernetes-e2e-kind/1866694290139254784 shows that it triggered those tests which is related to PodIndexLabel.

k8s-ci-robot · 2025-01-21T08:37:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlory
Once this PR has been reviewed and has the lgtm label, please assign kow3ns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

test/e2e/apps/OWNERS
test/e2e/feature/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-triage-robot · 2025-04-21T09:22:42Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

carlory · 2025-04-21T09:53:45Z

/remove-lifecycle stale
/test pull-kubernetes-cmd

Signed-off-by: carlory <[email protected]>

carlory · 2025-06-30T06:45:07Z

/cc @kannon92

aojea · 2025-06-30T14:53:12Z

test/e2e/apps/statefulset.go

@@ -1173,7 +1172,7 @@ var _ = SIGDescribe("StatefulSet", func() {
 		})
 	})

-	f.Describe("Deploy clustered applications", feature.StatefulSet, framework.WithSlow(), func() {
+	f.Describe("Deploy clustered applications", framework.WithSlow(), func() {


this depends on these manifests

zookeeperManifestPath = "test/e2e/testing-manifests/statefulset/zookeeper" mysqlGaleraManifestPath = "test/e2e/testing-manifests/statefulset/mysql-galera" redisManifestPath = "test/e2e/testing-manifests/statefulset/redis" cockroachDBManifestPath = "test/e2e/testing-manifests/statefulset/cockroachdb"

I do not think we want to pull these things by default, so the feature tag seems a good guardrail here

test/e2e/testing-manifests/statefulset/redis/statefulset.yaml: image: registry.k8s.io/e2e-test-images/pets/redis-installer:1.5 test/e2e/testing-manifests/statefulset/redis/statefulset.yaml: imagePullPolicy: Always test/e2e/testing-manifests/statefulset/redis/statefulset.yaml: image: debian:jessie test/e2e/testing-manifests/statefulset/redis/statefulset.yaml: image: debian:jessie test/e2e/testing-manifests/statefulset/etcd/statefulset.yaml: image: registry.k8s.io/etcd:3.2.24 test/e2e/testing-manifests/statefulset/etcd/statefulset.yaml: imagePullPolicy: Always test/e2e/testing-manifests/statefulset/etcd/tester.yaml: image: registry.k8s.io/etcd-statefulset-e2e-test:0.0 test/e2e/testing-manifests/statefulset/etcd/tester.yaml: imagePullPolicy: Always test/e2e/testing-manifests/statefulset/mysql-galera/statefulset.yaml: image: registry.k8s.io/galera-install:0.1 test/e2e/testing-manifests/statefulset/mysql-galera/statefulset.yaml: imagePullPolicy: Always test/e2e/testing-manifests/statefulset/mysql-galera/statefulset.yaml: image: debian:jessie test/e2e/testing-manifests/statefulset/mysql-galera/statefulset.yaml: image: registry.k8s.io/mysql-galera:e2e test/e2e/testing-manifests/statefulset/mysql-upgrade/statefulset.yaml: image: mysql:5.7 test/e2e/testing-manifests/statefulset/mysql-upgrade/statefulset.yaml: image: gcr.io/google-samples/xtrabackup:1.0 test/e2e/testing-manifests/statefulset/mysql-upgrade/statefulset.yaml: image: mysql:5.7.15 test/e2e/testing-manifests/statefulset/mysql-upgrade/statefulset.yaml: image: gcr.io/google-samples/xtrabackup:1.0 test/e2e/testing-manifests/statefulset/mysql-upgrade/tester.yaml: image: registry.k8s.io/mysql-e2e-test:0.1 test/e2e/testing-manifests/statefulset/mysql-upgrade/tester.yaml: imagePullPolicy: Always test/e2e/testing-manifests/statefulset/cassandra/statefulset.yaml: image: gcr.io/google-samples/cassandra:v13 test/e2e/testing-manifests/statefulset/cassandra/statefulset.yaml: imagePullPolicy: Always test/e2e/testing-manifests/statefulset/cassandra/tester.yaml: image: registry.k8s.io/cassandra-e2e-test:0.1 test/e2e/testing-manifests/statefulset/cassandra/tester.yaml: imagePullPolicy: Always test/e2e/testing-manifests/statefulset/cassandra/controller.yaml: image: gcr.io/google-samples/cassandra:v13 test/e2e/testing-manifests/statefulset/cockroachdb/statefulset.yaml: image: cockroachdb/cockroach-k8s-init:0.1 test/e2e/testing-manifests/statefulset/cockroachdb/statefulset.yaml: imagePullPolicy: IfNotPresent test/e2e/testing-manifests/statefulset/cockroachdb/statefulset.yaml: image: cockroachdb/cockroach:v1.0 test/e2e/testing-manifests/statefulset/cockroachdb/statefulset.yaml: imagePullPolicy: IfNotPresent test/e2e/testing-manifests/statefulset/zookeeper/statefulset.yaml: image: registry.k8s.io/e2e-test-images/pets/zookeeper-installer:1.5 test/e2e/testing-manifests/statefulset/zookeeper/statefulset.yaml: imagePullPolicy: Always test/e2e/testing-manifests/statefulset/zookeeper/statefulset.yaml: image: java:openjdk-8-jr

aojea · 2025-06-30T14:54:31Z

@carlory commented, based on the comments I think that only the PodIndexLabel feature makes sense to remove, the statefuslet needs further analysis and discussion with the SIG owner, but I do not think we want to run arbitrary images by default on our tests

k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 11, 2024

k8s-ci-robot requested review from atiratree and liggitt December 11, 2024 04:00

kannon92 reviewed Dec 12, 2024

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2024

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2025

carlory force-pushed the e2e-apps branch from 2a14e30 to 24c4030 Compare January 21, 2025 08:36

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 21, 2025

carlory force-pushed the e2e-apps branch from 24c4030 to 2b43b34 Compare January 21, 2025 08:38

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2025

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2025

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2025

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2025

carlory force-pushed the e2e-apps branch from 2b43b34 to a3eba91 Compare June 30, 2025 06:41

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2025

carlory force-pushed the e2e-apps branch from a3eba91 to 0012a06 Compare June 30, 2025 06:43

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 30, 2025

e2e apps: remove unnecessary feature labels

40943ef

Signed-off-by: carlory <[email protected]>

carlory force-pushed the e2e-apps branch from 0012a06 to 40943ef Compare June 30, 2025 06:43

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2025

k8s-ci-robot requested a review from kannon92 June 30, 2025 06:45

aojea reviewed Jun 30, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

e2e apps: remove unnecessary feature labels #129154

e2e apps: remove unnecessary feature labels #129154

carlory commented Dec 11, 2024 •

edited

Loading

Uh oh!

k8s-ci-robot commented Dec 11, 2024

Uh oh!

k8s-ci-robot commented Dec 11, 2024

Uh oh!

kannon92 Dec 12, 2024

Uh oh!

aojea Jun 30, 2025

Uh oh!

kannon92 commented Dec 12, 2024

Uh oh!

kannon92 commented Dec 12, 2024

Uh oh!

carlory commented Dec 13, 2024

Uh oh!

carlory commented Dec 13, 2024

Uh oh!

k8s-ci-robot commented Jan 21, 2025

Uh oh!

k8s-triage-robot commented Apr 21, 2025

Uh oh!

carlory commented Apr 21, 2025

Uh oh!

carlory commented Jun 30, 2025

Uh oh!

aojea Jun 30, 2025

Uh oh!

aojea commented Jun 30, 2025

Uh oh!

Uh oh!

		@@ -446,7 +445,7 @@ done`}
		*/
		// TODO: once this test is stable, squash the functionality into pre-existing conformance test called "should create

e2e apps: remove unnecessary feature labels #129154

Are you sure you want to change the base?

e2e apps: remove unnecessary feature labels #129154

Conversation

carlory commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Dec 11, 2024

Uh oh!

k8s-ci-robot commented Dec 11, 2024

Uh oh!

kannon92 Dec 12, 2024

Choose a reason for hiding this comment

Uh oh!

aojea Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

kannon92 commented Dec 12, 2024

Uh oh!

kannon92 commented Dec 12, 2024

Uh oh!

carlory commented Dec 13, 2024

Uh oh!

carlory commented Dec 13, 2024

Uh oh!

k8s-ci-robot commented Jan 21, 2025

Uh oh!

k8s-triage-robot commented Apr 21, 2025

Uh oh!

carlory commented Apr 21, 2025

Uh oh!

carlory commented Jun 30, 2025

Uh oh!

aojea Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

aojea commented Jun 30, 2025

Uh oh!

Uh oh!

carlory commented Dec 11, 2024 •

edited

Loading