Skip to content

remove 'endpointsleases' and 'configmapsleases' from usage #127655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

remove 'endpointsleases' and 'configmapsleases' from usage #127655

merged 1 commit into from
Jun 24, 2025
+11 −11

Conversation

guozheng-shen
Copy link
Contributor

@guozheng-shen guozheng-shen commented Sep 26, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

remove 'endpointsleases' and 'configmapsleases' from usage， because they've been removed

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Remove the 'endpointsleases' and 'configmapsleases' options from leader-elect-resource-lock in LeaderElectionConfiguration, as they have already been removed.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 26, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @guozheng-shen. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 26, 2024
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@Jefftree
Copy link
Member

Jefftree commented Sep 26, 2024 •
edited
Loading

/ok-to-test

Doing a quick search in the codebase shows some usage of non-lease resource locks in the tests. https://github.com/search?q=repo%3Akubernetes%2Fkubernetes+ResourceLock&type=code&p=2

eg:

kubernetes/pkg/controller/apis/config/fuzzer/fuzzer.go

Lines 35 to 36 in 996e674

if obj.Generic.LeaderElection.ResourceLock == "" {
obj.Generic.LeaderElection.ResourceLock = "endpoints"

can we remove those?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 26, 2024
@guozheng-shen
Copy link
Contributor Author

/ok-to-test

Doing a quick search in the codebase shows some usage of non-lease resource locks in the tests. https://github.com/search?q=repo%3Akubernetes%2Fkubernetes+ResourceLock&type=code&p=2

eg:

kubernetes/pkg/controller/apis/config/fuzzer/fuzzer.go

Lines 35 to 36 in 996e674

if obj.Generic.LeaderElection.ResourceLock == "" {
obj.Generic.LeaderElection.ResourceLock = "endpoints"

can we remove those?

@guozheng-shen guozheng-shen reopened this Sep 26, 2024
@guozheng-shen
Copy link
Contributor Author

/ok-to-test

Doing a quick search in the codebase shows some usage of non-lease resource locks in the tests. https://github.com/search?q=repo%3Akubernetes%2Fkubernetes+ResourceLock&type=code&p=2

eg:

kubernetes/pkg/controller/apis/config/fuzzer/fuzzer.go

Lines 35 to 36 in 996e674

if obj.Generic.LeaderElection.ResourceLock == "" {
obj.Generic.LeaderElection.ResourceLock = "endpoints"

can we remove those?

I think it ok， can I remove them all together?

@Jefftree
Copy link
Member

/ok-to-test
Doing a quick search in the codebase shows some usage of non-lease resource locks in the tests. https://github.com/search?q=repo%3Akubernetes%2Fkubernetes+ResourceLock&type=code&p=2
eg:

kubernetes/pkg/controller/apis/config/fuzzer/fuzzer.go

Lines 35 to 36 in 996e674

if obj.Generic.LeaderElection.ResourceLock == "" {
obj.Generic.LeaderElection.ResourceLock = "endpoints"

can we remove those?

I think it ok， can I remove them all together?

yes. We should remove all non lease usages in code if we're removing it from the documentation.

@guozheng-shen
Copy link
Contributor Author

/ok-to-test
Doing a quick search in the codebase shows some usage of non-lease resource locks in the tests. https://github.com/search?q=repo%3Akubernetes%2Fkubernetes+ResourceLock&type=code&p=2
eg:

kubernetes/pkg/controller/apis/config/fuzzer/fuzzer.go

Lines 35 to 36 in 996e674

if obj.Generic.LeaderElection.ResourceLock == "" {
obj.Generic.LeaderElection.ResourceLock = "endpoints"

can we remove those?

I think it ok， can I remove them all together?

yes. We should remove all non lease usages in code if we're removing it from the documentation.

Okay, I will complete it as soon as possible.

@cici37
Copy link
Contributor

cici37 commented Sep 26, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2024
@Jefftree
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0ebee0c7747cddfc91140bd9dcb72ebead50672b

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 26, 2025
@seans3
Copy link
Contributor

seans3 commented Jan 28, 2025

/remove-lifecycle stale
/lifecycle frozen
/assign

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

@seans3: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/remove-lifecycle stale
/lifecycle frozen
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jpbetz
Copy link
Contributor

jpbetz commented Apr 16, 2025

/approve
Leaning on @Jefftree's review

@deads2k
Copy link
Contributor

deads2k commented Jun 24, 2025

/approve

@Jefftree
Copy link
Member

/test pull-kubernetes-cmd

@dims
Copy link
Member

dims commented Jun 24, 2025

/approve
/lgtm

(cloud provider tests)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dims, guozheng-shen, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5b1af0c into kubernetes:master Jun 24, 2025
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 24, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Apps Jun 24, 2025
This was referenced Jun 25, 2025
Open
Open
@lmktfy
Copy link

lmktfy commented Jun 26, 2025

Changelog entry suggestion

Removed the `endpointsleases` and `configmapsleases` options from `leader-elect-resource-lock` in leader election configuration`, as the mechanisms they configured had already been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cici37 cici37 Awaiting requested review from cici37

@mikedanese mikedanese Awaiting requested review from mikedanese

@Jefftree Jefftree Awaiting requested review from Jefftree

@jpbetz jpbetz Awaiting requested review from jpbetz

@sttts sttts Awaiting requested review from sttts

Assignees

@dims dims

@jpbetz jpbetz

@sttts sttts

@seans3 seans3

@Jefftree Jefftree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Status: Done
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.