Skip to content

Fail Kubelet at startup if swap is configured with cgroup v1 #122241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fail Kubelet at startup if swap is configured with cgroup v1 #122241

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
067db0d
Fail Kubelet at startup if swap is configured with cgroup v1
iholder101 Jul 12, 2023
bbf69eb
add logs
kannon92 Jan 10, 2024
56c309e
add a new case for workloads using swap
kannon92 Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/kubelet/app/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,6 +803,7 @@ func run(ctx context.Context, s *options.KubeletServer, kubeDeps *kubelet.Depend
return fmt.Errorf("topology manager policy options %v require feature gates %q enabled",
s.TopologyManagerPolicyOptions, features.TopologyManagerPolicyOptions)
}
klog.InfoS("Swap Value", "failSwapOn", s.FailSwapOn)

kubeDeps.ContainerManager, err = cm.NewContainerManager(
kubeDeps.Mounter,
Expand Down
2 changes: 2 additions & 0 deletions pkg/kubelet/cm/container_manager_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,8 @@ func NewContainerManager(mountUtil mount.Interface, cadvisorInterface cadvisor.I
return nil, fmt.Errorf("running with swap on is not supported, please disable swap! or set --fail-swap-on flag to false. /proc/swaps contained: %v", swapLines)
}
}
} else if !cgroups.IsCgroup2UnifiedMode() {
return nil, fmt.Errorf("failSwapOn is %v but running swap with cgroups v1 is not supported", failSwapOn)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that what you want to do is

if failSwapOn && !cgroups.IsCgroup2UnifiedMode()  {
  return nil, fmt.Errorf("failSwapOn is %v but running swap with cgroups v1 is not supported", failSwapOn)
}

and this before the if in line 207

}

var internalCapacity = v1.ResourceList{}
Expand Down