Skip to content

Skip unit tests that assume the system does not use cgroup v2. #119329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Skip unit tests that assume the system does not use cgroup v2. #119329

wants to merge 1 commit into from

Conversation

brianpursley
Copy link
Member

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Since 4e20a8f, some of the kuberuntime unit tests fail when run on systems that have cgroup v2 unified mode (Ubuntu 22.04 in my case).

The test failures are not happening in the build pipeline, only when you are running them locally on a system with cgroup v2 unified mode (stat -fc %T /sys/fs/cgroup returns cgroup2fs )

This PR checks for cgroup v2 unified mode, and if detected, skips the tests that fail when running on a system using cgroup v2 unidified mode.

Which issue(s) this PR fixes:

Special notes for your reviewer:

This is an alternate solution to the problem proposed by #119292 (comment)

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 14, 2023
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and mtaufen July 14, 2023 13:08
@brianpursley brianpursley mentioned this pull request Jul 14, 2023
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: brianpursley
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 14, 2023
@ffromani
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 14, 2023
@SergeyKanzhelev
Copy link
Member

/assign @ffromani

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Jul 19, 2023
Closed
@bart0sh
Copy link
Contributor

bart0sh commented Jul 24, 2023

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 24, 2023
marquiz
marquiz reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianpursley is this PR still valid (i.e. tests failing) or this be closed? #118764 should've fixed these issues.

@brianpursley
Copy link
Member Author

@brianpursley is this PR still valid (i.e. tests failing) or this be closed? #118764 should've fixed these issues.

Yes, that PR seems to have fixed the problem. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz left review comments

@feiskyer feiskyer Awaiting requested review from feiskyer

@mtaufen mtaufen Awaiting requested review from mtaufen

Assignees

@ffromani ffromani

Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brianpursley @k8s-ci-robot @ffromani @SergeyKanzhelev @bart0sh @marquiz