Skip to content

Fix TestConditionalProgressRequester and TestWaitUntilFreshAndListTimeout flakes #119252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2023
Merged

Fix TestConditionalProgressRequester and TestWaitUntilFreshAndListTimeout flakes #119252

merged 1 commit into from
Jul 12, 2023

Conversation

serathius
Copy link
Contributor

/kind flake

NONE

Fixes #119244
/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 12, 2023
@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 12, 2023
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 12, 2023
@serathius serathius mentioned this pull request Jul 12, 2023
Merged
@wojtek-t
Copy link
Member

@serathius - did you run tests with stress as @aojea suggested elsewhere? If so, can you paste the output of that here?

@serathius serathius changed the title Fix TestConditionalProgressRequester and TestWaitUntilFreshAndListTimout flakes Fix TestConditionalProgressRequester and TestWaitUntilFreshAndListTimeout flakes Jul 12, 2023
@serathius
Copy link
Contributor Author

Compared flakiness with and without this change. With this PR:

  • TestWaitUntilFreshAndListTimeout flakiness went from 21% to 0% (verified over 1k runs)
  • TestConditionalProgressRequester flakiness went from 0.1% to 0% (verified over 6k runs)

Script used

apiserver $ go test ./pkg/storage/cacher/ -race -c
apiserver $ stress ./cacher.test --test.run 'TestWaitUntilFreshAndListTimeout'

@serathius
Copy link
Contributor Author

/retest

@wojtek-t
Copy link
Member

great - thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a6082bfc0dd49b4b4d1ac5571a64b42307784615

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@serathius
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit da2d500 into kubernetes:master Jul 12, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 12, 2023
@jiahuif
Copy link
Member

jiahuif commented Jul 13, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

Failure cluster [7274a82c...] TestWaitUntilFreshAndListTimeout flakes
4 participants
@serathius @wojtek-t @k8s-ci-robot @jiahuif