Check dbus error on container runtime start/stop #119197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bobbypage |
We should evaluate the error, otherwise we risk to hang indefinately on waiting for the `reschan` in: https://github.com/kubernetes/kubernetes/blob/64939b66c65b7c3daac41ece56776582532bf94b/test/e2e_node/util.go#L419 We also increase the timeout, because it can take a bit longer for runtimes to determinate depending on the work they have to be done on running containers. Signed-off-by: Sascha Grunert <[email protected]>
32f98a5 to
3bae26a
Compare
|
@kubernetes/sig-node-pr-reviews PTAL |
|
Thanks for fix! /lgtm |
|
LGTM label has been added. Git tree hash: 295543c2718bcfde73eeaa01708ef487805c6791
|
|
PTAL @tallclair @derekwaynecarr @klueska @sjenning @mrunalp @SergeyKanzhelev @endocrimes for test framework approval |
|
LGTM 👍 Thank you! |
|
/priority important-soon |
|
Thank you! /lgtm |
|
/assign @SergeyKanzhelev @mrunalp |
|
/assign @haircommander |
|
/lgtm |
|
PTAL @tallclair @derekwaynecarr @klueska @sjenning @mrunalp @SergeyKanzhelev @endocrimes for test framework approval |
31 tasks
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
We should evaluate the error, otherwise we risk to hang indefinately on waiting for the
reschanin:kubernetes/test/e2e_node/util.go
Line 419 in 64939b6
We also increase the timeout, because it can take a bit longer for runtimes to determinate depending on the work they have to be done on running containers.
Which issue(s) this PR fixes:
Fixes #116872
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: