Skip to content

KEP-3063: dynamic resource allocation: update kubelet plugin RPC versions supported. #4164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 5, 2023
Merged

KEP-3063: dynamic resource allocation: update kubelet plugin RPC versions supported. #4164

merged 6 commits into from
Sep 5, 2023

Conversation

byako
Copy link
Contributor

@byako byako commented Aug 28, 2023

  • One-line PR description: update kubelet section of README.md with new RPC version introduced in 1.28

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 28, 2023
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Aug 28, 2023
@k8s-ci-robot k8s-ci-robot requested a review from mrunalp August 28, 2023 20:39
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2023
@byako byako mentioned this pull request Aug 28, 2023
Merged
@bart0sh
Copy link
Contributor

bart0sh commented Aug 29, 2023

/assign @bartosh @klueska @pohly

@k8s-ci-robot
Copy link
Contributor

@bart0sh: GitHub didn't allow me to assign the following users: bartosh.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @bartosh @klueska @pohly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bart0sh
Copy link
Contributor

bart0sh commented Aug 29, 2023

/assign

@bart0sh
Copy link
Contributor

bart0sh commented Aug 29, 2023

/retest

klueska
klueska reviewed Sep 5, 2023
View reviewed changes
keps/sig-node/3063-dynamic-resource-allocation/README.md Outdated

- [v1alpha2](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubelet/pkg/apis/dra/v1alpha2/api.proto)
interface provides resource claim information to kubelet plugin on one at a
time basis. **NB! v1alpha2 will be deprecared, switch to v1alpha3**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this NB!? It just renders as the letters NB here:
https://github.com/kubernetes/enhancements/pull/4164/files#diff-8fa237d276346416c2aafa209f721e43c9762f59cabec234eafafe01694de3ee

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An acronym signifying the importans, similar to NOTE! or MIND THAT...
https://en.wikipedia.org/wiki/Nota_bene

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove it. I cant be alone in never seeing this acronym before and it doesn't seem to render as anything special in the markdown.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

klueska
klueska reviewed Sep 5, 2023
View reviewed changes
klueska
klueska reviewed Sep 5, 2023
View reviewed changes
klueska
klueska reviewed Sep 5, 2023
View reviewed changes
klueska
klueska reviewed Sep 5, 2023
View reviewed changes
@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: byako, dchen1107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 175a24a into kubernetes:master Sep 5, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 5, 2023
@pohly pohly mentioned this pull request Nov 6, 2023
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klueska klueska klueska left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@pohly pohly

@klueska klueska

@dchen1107 dchen1107

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
6 participants
@byako @bart0sh @k8s-ci-robot @dchen1107 @klueska @pohly