Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate MediaService to androidx.media2 for paging in Android Auto #615

Open
Maxr1998 opened this issue Jan 28, 2022 · 8 comments
Open

Migrate MediaService to androidx.media2 for paging in Android Auto #615

Maxr1998 opened this issue Jan 28, 2022 · 8 comments
Labels
blocked Blocked for some reason enhancement New feature or request

Comments

@Maxr1998
Copy link
Member

Maxr1998 commented Jan 28, 2022

Using MediaLibraryService instead of MediaBrowserCompat, we can return pages of data, which should fix #284.

Depending on the complexity, it might be better to wait for androidx.media3.

@Maxr1998 Maxr1998 added the enhancement New feature or request label Jan 28, 2022
@kaysond
Copy link

kaysond commented Apr 30, 2022

@Maxr1998 any current thoughts on using media2 or media3? Looks like there's already an alpha version of 3, so it'll probably release by end of the year. Might be an option to work on media3 in a separate branch as a beta release track?

I'd be interested in working on this, though to be honest, it's been a long time since I did anything android-related.

@Maxr1998
Copy link
Member Author

Maxr1998 commented May 4, 2022

I first wanted to upgrade ExoPlayer to the latest version and finally finish and merge the transcoding selection in #535.
Afterwards, we could indeed try migrating to media3.

@Maxr1998 Maxr1998 added the blocked Blocked for some reason label May 4, 2022
@foss-
Copy link

foss- commented Dec 12, 2023

Seeing that ExoPlayer was updated to 2.19.1, the last planned exoplayer release, in 2.6.0 and #535 being merged a while ago, are there plans for the media3 migration? Couldn't find a separate issue so asking here.

@nielsvanvelzen
Copy link
Member

I made the media3 migration in #1118 but @Maxr1998 wanted to do some other stuff first so it was postponed.

@Maxr1998
Copy link
Member Author

Yes, I want to get in the UI rewrite first but I haven't been able to work on it recently. Too busy with work and university, unfortunately.

@channeladam
Copy link

FYI - the latest media3 (release v1.2.1 on 17 January 2024 - https://github.com/androidx/media/releases/tag/1.2.1) finally fixes the annoying 3 year old bug with the OPUS and VORBIS channel layouts being wrong for 3, 5, 6, 7 and 8 channels (google/ExoPlayer#8396).

It would be awesome to have that!

@channeladam
Copy link

@nielsvanvelzen I happened to notice the Android TV Roadmap (https://github.com/orgs/jellyfin/projects/47/views/1) and saw that exoplayer has been replaced with media3 there
(jellyfin/jellyfin-androidtv#2826)

I don't know much about how the Jellyfin code changes are coordinated - but I was wondering if there was an update regarding the Jellyfin Android app and media3 ? (since it apparently fixes the OPUS and VORBIS channel layout issue)

Thank you!

@nielsvanvelzen
Copy link
Member

Eventually the mobile app will share the playback code with the Android TV app (the plan is to unify both apps). Until that happens the mobile and TV app will have separate playback implementations with different feature sets.
I worked on the media3 migration a while back (#1118) but it was put on hold (as mentioned above). No current ETA on when we'll upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked for some reason enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants