kube: cleanup crdwatcher a bit #44145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hzxuzhonghu I put a hold sinec I am not 100% sure this is correct yet, going to self-review it a bit more tomorrow. But wanted to put it up for feedback |
|
Sorry for the delay i am a little busy with other work. Will take a look later |
hzxuzhonghu
reviewed
Mar 30, 2023
Comment on lines
188
to
189
| if !cl.crdWatcher.Known(s.GroupVersionResource()) { | ||
| cl.logger.Warnf("Skipping CRD %v as it is not present", s.GroupVersionKind()) |
There was a problem hiding this comment.
The log skipping is confusing, maybe CRD xx is not yet present, will be handled latter once it is created
hzxuzhonghu
reviewed
Mar 30, 2023
howardjohn
commented
Apr 1, 2023
cc7fe87 to
5718d64
Compare
|
/test all |
5718d64 to
340e844
Compare
|
/test all |
340e844 to
20f7745
Compare
|
/test all |
20f7745 to
a99f3fb
Compare
|
/test all |
a99f3fb to
4feac7f
Compare
|
/test all |
4feac7f to
6a45fa4
Compare
stevenctl
reviewed
May 15, 2023
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
May 19, 2023
Pull fixes out of istio#44201 and istio#44145
87ed219 to
efb8bbe
Compare
istio-testing
pushed a commit
that referenced
this pull request
May 22, 2023
23b9883 to
d924f75
Compare
hzxuzhonghu
reviewed
May 23, 2023
| // already started, ignore | ||
| default: | ||
| c.stop = stop | ||
| close(c.running) |
There was a problem hiding this comment.
This is not concurrent safe, will panic if called concurrently
There was a problem hiding this comment.
thanks, added a mutex
| } | ||
| inf.Start(stop) | ||
| // Swap out the dummy client with the full one | ||
| delayedClient.set(fc) |
0317fdd to
f07931a
Compare
* Remove syncronous List; it is duplicated with the informer * Refactoring ordering a bit * use kclient which ensures handler is called once we check HasSynced
f07931a to
4793472
Compare
|
@howardjohn: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4793472 to
e6ac82c
Compare
hanxiaop
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit: lets do #44899 first, then I will rebase this.This reworks how we enable optional watchers, which will watch only if the CRD is present.
Today, we do this a few different ways for variuous usages. This standardizes on a single implementation in
kclient.Clients can specify a "Delay" which will result in a client that may exist now or at some future point:
For example:
Aside from the filter during creation, usage for this is completely transparent. The kclient will ensure that we only return HasSynced=true once the CRD is ready and we start watching OR the CrdWatcher has finished syncing and the CRD did not exist.