Skip to content

Adding e2e tests for Android and IOS #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 25, 2025
Merged

Conversation

kilian-tennyson
Copy link
Contributor

Description

Add e2e tests for android & ios as a foundation for automated updates.

Next, we will leverage these basic tests to build into the CI.

Screen.Recording.2025-06-23.at.10.41.44.mov

@uddish
Copy link
Contributor

uddish commented Jun 23, 2025

I don't see any maestro dependencies being added in the PR.
Will it be part of a separate PR 🤔

@kilian-tennyson
Copy link
Contributor Author

I don't see any maestro dependencies being added in the PR. Will it be part of a separate PR 🤔

Hey Uddish,
Yeah, was planning on adding them as part of the build PR next, but could add them here too of course!

@uddish
Copy link
Contributor

uddish commented Jun 23, 2025

I think we can add the dependencies first to check if the CI is passing and the build is running okay in case we need to revert it. But happy approve this first too if you think otherwise 😄

@kilian-tennyson
Copy link
Contributor Author

I think we can add the dependencies first to check if the CI is passing and the build is running okay in case we need to revert it. But happy approve this first too if you think otherwise 😄

No, that sounds like a great idea! Will do that, thanks

uddish
uddish previously approved these changes Jun 25, 2025
Copy link
Contributor

@uddish uddish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@kilian-tennyson kilian-tennyson merged commit 963e595 into main Jun 25, 2025
8 checks passed
@kilian-tennyson kilian-tennyson deleted the maestro_playground branch June 25, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants