Skip to content

add block contact API to unstable version #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2025
Merged

add block contact API to unstable version #202

merged 4 commits into from
Feb 25, 2025

Conversation

dan0505
Copy link
Contributor

@dan0505 dan0505 commented Feb 24, 2025 •
edited
Loading

https://github.com/intercom/intercom/issues/382977

Why?
Add block user endpoint to unstable open_api.yml

image

not to get confused by the Intercom-Version - Available values which contains all the versions
those are acceptable values for this filed, and the contacts/:id/block endpoint is only available on Unstable version

Actual implementation: https://github.com/intercom/intercom/pull/384449

@steve-henry
Copy link
Contributor

@dan0505 Is your screenshot mostly showing the unarchive endpoint?

@dan0505
Copy link
Contributor Author

dan0505 commented Feb 25, 2025

@dan0505 Is your screenshot mostly showing the unarchive endpoint?

Indeed, thanks fixed

@steve-henry
Copy link
Contributor

steve-henry commented Feb 25, 2025 •
edited
Loading

Non-blocking: Do we have any field to say a user has been blocked? I'm aware this is the docs PR, but could the response contain something to say the user is blocked.

I'm looking at the example. The schema in the code mentions blocked

@dan0505
Copy link
Contributor Author

dan0505 commented Feb 25, 2025

Non-blocking: Do we have any field to say a user has been blocked? I'm aware this is the docs PR, but could the response contain something to say the user is blocked.

Non-blocking: Do we have any field to say a user has been blocked? I'm aware this is the docs PR, but could the response contain something to say the user is blocked.

I'm looking at the example. The schema in the code mentions blocked

Sorry again, my bad, the example should be "blocked": true now fixed

steve-henry
steve-henry approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@steve-henry steve-henry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌🏻

@dan0505 dan0505 merged commit 8cd83dd into main Feb 25, 2025
4 checks passed
@dan0505 dan0505 deleted the dq/add-block-user-api branch February 25, 2025 09:39
@dan0505 dan0505 mentioned this pull request Feb 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steve-henry steve-henry steve-henry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan0505 @steve-henry