Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected punctuation characters are emitted when client keyboard layout is not English #1119

Open
ghost opened this issue Nov 4, 2021 · 0 comments
Labels
barrier-import Imported from Barrier - likely outdated.

Comments

@ghost
Copy link

ghost commented Nov 4, 2021

This issue has been migrated from old Barrier Github repository debauchee/barrier#1119

Issue created on: 2021-04-06 by @MadaraUchiha
Issue last updated on: 2021-08-11

Describe the bug
When the target keyboard layout is set to a layout that doesn't match the host (in my case, QWERTY English), characters like , . / ' are emitted instead of the target layout character in that position.

For example, when the keyboard layout is set to Hebrew, pressing the key that in English layout would be , should cause the character ת to be emitted, instead, , is emitted.

To Reproduce

Steps to reproduce the behavior:

  1. Setup a normal session
  2. Enable Hebrew layout for the client
  3. Set client layout to Hebrew
  4. Open any text editor
  5. Press the , key

Expected behavior
The client should type ת onto the text editor.

Actual behavior
The client types , onto the text editor.

Screenshots
N/A

Desktop (please complete the following information):

  • OS: Windows (client: Mac)
  • Barrier version 2.3.3

Additional context

In the case of the Hebrew layout (but probably in other layouts as well), the punctuation keys are laid out differently, for example, to type , in Hebrew, you'd press the key in the QWERTY layout position of ', to type . you'd hit / and so on. Since these keys appear in both layout (albeit in different positions), the original English characters are emitted.

Hebrew characters (i.e. those that don't appear in the English QWERTY layout) work fine, you type m and get צ as expected, for instance.

Attached is an image of a Hebrew keyboard with the keys marked, for illustration
image

Related: #724 #860


Commented on: 2021-08-11 by @abutbul

Some info: This does reproduce in Windows 10 but does not in Linux (Ubuntu 20.04 for example).
I have been trying to find keyboard layouts in Windows which will not send , instead of ת but so far none have proven to work.

@shymega shymega added the barrier-import Imported from Barrier - likely outdated. label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
barrier-import Imported from Barrier - likely outdated.
Projects
None yet
Development

No branches or pull requests

1 participant