clean iterator prototype to allow tree shaking #2126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
X.prototype
is an old code style, and forbid tree-shaking of the library.As the 6.x branch will migrate to a modern coding style, let's start with the simple Iterator class.
Testing tree-shakeability
Replace the Immutable.js file by this
(for now the circular dependency makes it untestable if we import / export all)
Compiling this file with rollup
Will give the following output:
Previously, we add all the Iterator class in here!