Integrate immutable-js-oss fork into main repository #1833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Misha Wakerman <[email protected]>
* Migrate gulp 3 to 4 - Migrate gulp 3 to 4 - Support Node.js 10+ * Fix default task - Remove done callback
* Write failing test * fix test * Fix bug
* Fix bug links too * Update GH link * README.md * Formatting * Update some references to immutable-js * And that * Update git url * typo
* Update publishing GH pages * Not here * Update email
There is a small typo in type-definitions/tests/immutable-flow.js. Should read `interpreted` rather than `interpretted`. Co-authored-by: Tim Gates <[email protected]>
* Rename ./rescources/jest to ./resources/jest.sh * Oops * Update permissions * LF
* Add intellij files to gitignore * Use node native commands for build scripts
* Upgrade dtslint * Add required tsconfig property * Fix inherited types * Fix errors * Use Node LTS
* Upgrade ESLint * And tslint * Use default Node version * Use latest * Use Node LTS * master versions * Upgrade packages
* Upgrade prettier * Format * Fix locations of $ExpectError * Fix Flow types * Fix magic regex * Fix more merge conflict issues
* Separate formatting from test script * Build before we lint
* wip * links broken * wip * Progress on multi-version docs * Migrate docs to React 17 on ES6 * Migrate docs to React 17 on ES6 * Migrate docs to React 17 on ES6 * Fix routing and sidebar functionality * Fix markup rendering and implement version selection * Fix fsevents dependencies of build and test tools * Pretty format page generation code * Use CND script for older doc versions * Apply eslint to documentation * Fix version change path * Prevet tsc and dtslint from checking node_modules Co-authored-by: Conrad Buck <[email protected]>
* ensure that `subtract` works correcly Fixes immutable-js-oss#139 * Fix tslint issue Co-authored-by: Nathan Bierema <[email protected]>
Co-authored-by: Nathan Bierema <[email protected]>
Co-authored-by: Nathan Bierema <[email protected]>
This was referenced Jun 29, 2021
507db9b to
4971edd
Compare
ensure #1706 is fixed
Improve DX for tests in JS files too
bdurrer
reviewed
Jun 29, 2021
acusti
reviewed
Jun 29, 2021
acusti
reviewed
Jun 29, 2021
acusti
reviewed
Jun 29, 2021
acusti
reviewed
Jun 29, 2021
acusti
reviewed
Jun 29, 2021
acusti
reviewed
Jun 29, 2021
acusti
reviewed
Jun 29, 2021
acusti
reviewed
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does integrate the https://github.com/immutable-js-oss/immutable-js fork into the main repository main branch.
I think the only thing I did not import here is Use ranges in devDependencies. Apparently @leebyron does not use ranges, when @Methuselah96 and I prefer to (I do not know for other maintainters). I preferred keep the actual preferences here, but It may be discussed in another PR.
A (possibly sensible) think to discuss too I think is the FUNDING file. I do not know how does github funding works too, but actually, only @Methuselah96 is in here, @leebyron (at least) should probably be there too.
Next steps are :