Skip to content

feat(transact): support nested JSON txs #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 13, 2021
Merged

feat(transact): support nested JSON txs #48

merged 11 commits into from
Jan 13, 2021

Conversation

crs48
Copy link
Member

@crs48 crs48 commented Jan 4, 2021 •
edited
Loading

PR Description

PR Checklist

Testing

  • added relevant test coverage
  • no tests needed

Docs

  • added relevant docs
  • updated relevant sections in the README.md
  • updated relevant docstrings in index.d.ts
  • no docs needed

Typescript

  • added or edited relevant Typescript type declarations
  • no type declaration updates needed

@crs48 crs48 added the enhancement New feature or request label Jan 4, 2021
@crs48 crs48 requested a review from rubinovitz January 4, 2021 20:46
@crs48 crs48 self-assigned this Jan 4, 2021
rubinovitz
rubinovitz previously approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@rubinovitz rubinovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! excited to use this!

crs48 added 3 commits January 11, 2021 10:50
@crs48
fix(entity): handle arrays in recently touched attrs
b57aa16 
- removes nesting or keys in exchange for a flat map like the cache
- nesting could be ambiguous with the addition of arrays
  - E.g. { 'items': [], 'items,0,id': 1 } would not be the same items array
    - they are in practice two unrelated calls to entity.get
@crs48
docs(array): add array example
790e1c3
@crs48
fix(typos): fix some typos
02f5742
rubinovitz
rubinovitz approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@rubinovitz rubinovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest LGTM

@crs48 crs48 merged commit 86a4ac2 into master Jan 13, 2021
@crs48 crs48 deleted the add-cardinality-many-support branch January 13, 2021 19:03
@github-actions
Copy link

🎉 This PR is included in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubinovitz rubinovitz rubinovitz approved these changes

Assignees

@crs48 crs48

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crs48 @rubinovitz