Poll for new status after update #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@natefox how reliable is this 100ms delay? will sometimes it be 120ms needed, etc? if we know we are disabling, could we poll until it is actually disabled? maybe someone has a slow network or slow pi-hole |
|
As I've been reading piholes code, it looks like the delay is just from the
signal to FTLDNS to reload it's config. I've come around to agreeing that
polling is the right thing to do.
On vacation this week, will update my PR if someone doesn't beat me to it.
I'll also probably submit an enhancement PR to pihole to negate this need
but we'd still need to support these non-enhanhanced versions anyway.
…On Fri, Aug 9, 2024 at 10:15 AM Poat ***@***.***> wrote:
@natefox <https://github.com/natefox> how reliable is this 100ms delay?
will sometimes it be 120ms needed, etc?
if we know we are disabling, could we poll until it is actually disabled?
maybe someone has a slow network or slow pi-hole
—
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD5LRCUGWRWYB3SRHYKBSLZQT2K3AVCNFSM6AAAAABMFFRNSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZYGM4TEMBRGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
5a109c2 to
2f6ada0
Compare
|
Finally got around to updating this. Opted to keep the polling within the original |
|
so, just wanted to give feedback and say that this patch is working and has been working fine for me for a while. Is there any specific tests anyone would like me to do that might help get it merged? |
This was referenced Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes home-assistant/core#117052
See home-assistant/core#117052 (comment) for more detail