-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Add Sensor platform to NASweb integration #39779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe integration metadata for NASweb was updated to add "Sensor" as an additional category in the Changes
Sequence Diagram(s)No sequence diagram generated as the change is limited to metadata updates. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/nasweb.markdown
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
ha_category: | ||
- Sensor | ||
- Switch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha_platforms
list not updated to reflect newly-added Sensor category
You added the Sensor entry under ha_category
, but ha_platforms
still advertises only switch
.
This mismatch will cause the docs generator to omit the Sensor platform from rendered pages and can confuse users/glance checks in PR validation.
ha_platforms:
- - switch
+ - sensor
+ - switch
Please keep the list alphabetical (sensor
, switch
) to align with the rest of the docs repo.
Also applies to: 13-15
🤖 Prompt for AI Agents
In source/_integrations/nasweb.markdown around lines 4 to 6 and also lines 13 to
15, the ha_platforms list is not updated to include the newly added Sensor
category and is not in alphabetical order. Update the ha_platforms list to
include both sensor and switch entries, sorted alphabetically as sensor, switch,
to ensure consistency and proper documentation generation.
Proposed change
Add Sensor platform to NASweb integration
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit