-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Update light.markdown #39764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update light.markdown #39764
Conversation
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe documentation for the "Light card" was updated to change references from "the light" to "a light" in both the metadata description and the introductory paragraph, making the language more generic. Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_dashboards/light.markdown (1)
5-15
: Minor consistency nit-pick: capitalisation of “Light card”
Elsewhere in the doc (line 3 title, image alt text) “Light card” is capital-cased. Consider matching that here to keep style uniform:- description: "The light card allows you to change the brightness of a light." + description: "The Light card allows you to change the brightness of a light."Same applies to the sentence on line 15.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_dashboards/light.markdown
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_dashboards/light.markdown (1)
5-5
: Clarity improved – wording update is correct
The replacement of “the light” with “a light” accurately generalises the description.
Proposed change
As the Light card can control any of the installed lights the wording needs to reflect that by using "a light" instead of "the light".
This mirrors the identical change made to the description in Frontend in home-assistant/frontend#25988
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit