-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Tailscale integration documentation improvements #39750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the Tailscale integration documentation to improve clarity and usability. Key changes include a revised introduction with clearer integration details, a restructured prerequisites section with numbered steps, and enhanced troubleshooting instructions.
Warning Rate limit exceeded@frenck has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 15 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Tailscale integration documentation was extensively rewritten and expanded. The update introduces detailed usage explanations, configuration instructions, supported features, example automations, troubleshooting guidance, and removal steps, replacing the previous brief description. No code or API changes were made; only documentation content was modified. Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to documentation updates. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (4)
source/_integrations/tailscale.markdown (4)
28-31
: Insert blank line before the enumerated list inside the admonitionMarkdown-lint (MD032) complains because lists must be preceded by a blank line.
Adding a single newline after the introductory sentence satisfies the rule and renders the list correctly in the docs.-To access Home Assistant remotely via Tailscale: -1. Install Tailscale directly on your Home Assistant device +To access Home Assistant remotely via Tailscale: + +1. Install Tailscale directly on your Home Assistant device
118-119
: Remove superfluous blank lineThere are two consecutive blank lines here (MD012).
Delete one to keep the markdown tidy.
133-135
: Minor grammar fixAdd the article “the” for clarity: “Check the key hasn’t expired …”.
- - Check key hasn't expired in the Tailscale admin panel + - Check **the** key hasn't expired in the Tailscale admin panel
149-151
: Terminate the final list item with a periodLanguageTool flagged the missing period; ending the sentence improves consistency.
-3. Your Tailscale network and devices continue operating normally +3. Your Tailscale network and devices continue operating normally.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/tailscale.markdown
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`source/_integrations/*`: Integration documentation must use the provided template structure and section order.
source/_integrations/*
: Integration documentation must use the provided template structure and section order.
📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)
List of files the instruction was applied to:
source/_integrations/tailscale.markdown
🪛 LanguageTool
source/_integrations/tailscale.markdown
[uncategorized] ~134-~134: You might be missing the article “the” here.
Context: ... correctly (no extra spaces) - Check key hasn't expired in the Tailscale admin p...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~151-~151: A period might be missing here.
Context: ... network and devices continue operating normally
(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/tailscale.markdown
29-29: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
118-118: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
source/_integrations/tailscale.markdown (1)
100-115
: Automation YAML still uses invalid schema – copy/paste will break for usersThe plural keys (
triggers
,conditions
,actions
) and thetrigger:
/action:
sub-keys are not recognised by Home Assistant. This was pointed out in the previous review and is still unresolved.-automation: - - alias: "Start backup when work laptop connects" - triggers: - - trigger: state - entity_id: binary_sensor.work_laptop_tailscale - from: "off" - to: "on" - conditions: - - condition: time - after: "18:00:00" # Only after work hours - before: "23:00:00" - actions: - - action: script.start_network_backup - - action: notify.admin - data: - message: "Starting automated backup - work laptop detected" +automation: + - alias: "Start backup when work laptop connects" + trigger: + - platform: state + entity_id: binary_sensor.work_laptop_tailscale + from: "off" + to: "on" + condition: + - condition: time + after: "18:00:00" # Only after work hours + before: "23:00:00" + action: + - service: script.start_network_backup + - service: notify.admin + data: + message: "Starting automated backup — work laptop detected"Please adjust the snippet so it loads correctly in Home Assistant.
🧹 Nitpick comments (3)
source/_integrations/tailscale.markdown (3)
28-31
: Add a blank line before the numbered list to satisfy markdown-lint (MD032)Lists must be surrounded by blank lines.
-To access Home Assistant remotely via Tailscale: +To access Home Assistant remotely via Tailscale: +
118-119
: Remove extra blank line (MD012)There are two consecutive blank lines after the YAML block; keep only one.
- -
151-151
: Terminate the sentence with a periodMinor punctuation nitpick for consistency.
-3. Your Tailscale network and devices continue operating normally +3. Your Tailscale network and devices continue operating normally.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/tailscale.markdown
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`source/_integrations/*`: Integration documentation must use the provided template structure and section order.
source/_integrations/*
: Integration documentation must use the provided template structure and section order.
📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)
List of files the instruction was applied to:
source/_integrations/tailscale.markdown
🪛 LanguageTool
source/_integrations/tailscale.markdown
[uncategorized] ~134-~134: You might be missing the article “the” here.
Context: ... correctly (no extra spaces) - Check key hasn't expired in the Tailscale admin p...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~151-~151: A period might be missing here.
Context: ... network and devices continue operating normally
(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/tailscale.markdown
29-29: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
118-118: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
Proposed change
As per title, a collection of documentation improvements for the Tailscale integration documentation.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit