Skip to content

Tailscale integration documentation improvements #39750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Jun 27, 2025

Proposed change

As per title, a collection of documentation improvements for the Tailscale integration documentation.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Significantly expanded and restructured the Tailscale integration documentation with detailed usage instructions, configuration guidance, and supported features.
    • Added sections on prerequisites, supported sensors and binary sensors, example automations, troubleshooting steps, and removal instructions.
    • Clarified integration capabilities, data update frequency, and setup requirements for remote access.

@Copilot Copilot AI review requested due to automatic review settings June 27, 2025 16:25
@home-assistant home-assistant bot added the current This PR goes into the current branch label Jun 27, 2025
Copy link

netlify bot commented Jun 27, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 7024624
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/685eca349cf9d7000856ddd7
😎 Deploy Preview https://deploy-preview-39750--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the Tailscale integration documentation to improve clarity and usability. Key changes include a revised introduction with clearer integration details, a restructured prerequisites section with numbered steps, and enhanced troubleshooting instructions.

Copy link
Contributor

coderabbitai bot commented Jun 27, 2025

Warning

Rate limit exceeded

@frenck has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 15 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between a3627d1 and 7024624.

📒 Files selected for processing (1)
  • source/_integrations/tailscale.markdown (1 hunks)
📝 Walkthrough

Walkthrough

The Tailscale integration documentation was extensively rewritten and expanded. The update introduces detailed usage explanations, configuration instructions, supported features, example automations, troubleshooting guidance, and removal steps, replacing the previous brief description. No code or API changes were made; only documentation content was modified.

Changes

File(s) Change Summary
source/_integrations/tailscale.markdown Expanded and restructured documentation: added detailed usage, configuration, supported features, example automations, troubleshooting, and removal instructions.

Sequence Diagram(s)

No sequence diagram generated as the changes are limited to documentation updates.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (4)
source/_integrations/tailscale.markdown (4)

28-31: Insert blank line before the enumerated list inside the admonition

Markdown-lint (MD032) complains because lists must be preceded by a blank line.
Adding a single newline after the introductory sentence satisfies the rule and renders the list correctly in the docs.

-To access Home Assistant remotely via Tailscale:
-1. Install Tailscale directly on your Home Assistant device
+To access Home Assistant remotely via Tailscale:
+
+1. Install Tailscale directly on your Home Assistant device

118-119: Remove superfluous blank line

There are two consecutive blank lines here (MD012).
Delete one to keep the markdown tidy.


133-135: Minor grammar fix

Add the article “the” for clarity: “Check the key hasn’t expired …”.

-   - Check key hasn't expired in the Tailscale admin panel
+   - Check **the** key hasn't expired in the Tailscale admin panel

149-151: Terminate the final list item with a period

LanguageTool flagged the missing period; ending the sentence improves consistency.

-3. Your Tailscale network and devices continue operating normally
+3. Your Tailscale network and devices continue operating normally.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between b0c8777 and 6aba607.

📒 Files selected for processing (1)
  • source/_integrations/tailscale.markdown (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`source/_integrations/*`: Integration documentation must use the provided template structure and section order.

source/_integrations/*: Integration documentation must use the provided template structure and section order.

📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)

List of files the instruction was applied to:

  • source/_integrations/tailscale.markdown
🪛 LanguageTool
source/_integrations/tailscale.markdown

[uncategorized] ~134-~134: You might be missing the article “the” here.
Context: ... correctly (no extra spaces) - Check key hasn't expired in the Tailscale admin p...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[uncategorized] ~151-~151: A period might be missing here.
Context: ... network and devices continue operating normally

(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)

🪛 markdownlint-cli2 (0.17.2)
source/_integrations/tailscale.markdown

29-29: Lists should be surrounded by blank lines
null

(MD032, blanks-around-lists)


118-118: Multiple consecutive blank lines
Expected: 1; Actual: 2

(MD012, no-multiple-blanks)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

♻️ Duplicate comments (1)
source/_integrations/tailscale.markdown (1)

100-115: Automation YAML still uses invalid schema – copy/paste will break for users

The plural keys (triggers, conditions, actions) and the trigger:/action: sub-keys are not recognised by Home Assistant. This was pointed out in the previous review and is still unresolved.

-automation:
-  - alias: "Start backup when work laptop connects"
-    triggers:
-      - trigger: state
-        entity_id: binary_sensor.work_laptop_tailscale
-        from: "off"
-        to: "on"
-    conditions:
-      - condition: time
-        after: "18:00:00"  # Only after work hours
-        before: "23:00:00"
-    actions:
-      - action: script.start_network_backup
-      - action: notify.admin
-        data:
-          message: "Starting automated backup - work laptop detected"
+automation:
+  - alias: "Start backup when work laptop connects"
+    trigger:
+      - platform: state
+        entity_id: binary_sensor.work_laptop_tailscale
+        from: "off"
+        to: "on"
+    condition:
+      - condition: time
+        after: "18:00:00"  # Only after work hours
+        before: "23:00:00"
+    action:
+      - service: script.start_network_backup
+      - service: notify.admin
+        data:
+          message: "Starting automated backup — work laptop detected"

Please adjust the snippet so it loads correctly in Home Assistant.

🧹 Nitpick comments (3)
source/_integrations/tailscale.markdown (3)

28-31: Add a blank line before the numbered list to satisfy markdown-lint (MD032)

Lists must be surrounded by blank lines.

-To access Home Assistant remotely via Tailscale:
+To access Home Assistant remotely via Tailscale:
+

118-119: Remove extra blank line (MD012)

There are two consecutive blank lines after the YAML block; keep only one.

-
-

151-151: Terminate the sentence with a period

Minor punctuation nitpick for consistency.

-3. Your Tailscale network and devices continue operating normally
+3. Your Tailscale network and devices continue operating normally.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 6aba607 and a3627d1.

📒 Files selected for processing (1)
  • source/_integrations/tailscale.markdown (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`source/_integrations/*`: Integration documentation must use the provided template structure and section order.

source/_integrations/*: Integration documentation must use the provided template structure and section order.

📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)

List of files the instruction was applied to:

  • source/_integrations/tailscale.markdown
🪛 LanguageTool
source/_integrations/tailscale.markdown

[uncategorized] ~134-~134: You might be missing the article “the” here.
Context: ... correctly (no extra spaces) - Check key hasn't expired in the Tailscale admin p...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[uncategorized] ~151-~151: A period might be missing here.
Context: ... network and devices continue operating normally

(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)

🪛 markdownlint-cli2 (0.17.2)
source/_integrations/tailscale.markdown

29-29: Lists should be surrounded by blank lines
null

(MD032, blanks-around-lists)


118-118: Multiple consecutive blank lines
Expected: 1; Actual: 2

(MD012, no-multiple-blanks)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

@frenck frenck merged commit 081ba5f into current Jun 27, 2025
9 checks passed
@frenck frenck deleted the frenck-2025-0332 branch June 27, 2025 17:22
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants