Skip to content

Add Rehlko Kohler 30RCL to list of generators that work. #39735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

PeteRager
Copy link
Contributor

@PeteRager PeteRager commented Jun 26, 2025

Proposed change

Add the 30RCL series to generators that work with the integration.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes Works with Kohler 30RCL #39595

Checklist

  • [X ] This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated the Rehlko integration documentation to include the "30RCL" generator model with a link to its product page.

@PeteRager PeteRager requested a review from bdraco as a code owner June 26, 2025 21:17
@home-assistant home-assistant bot added the current This PR goes into the current branch label Jun 26, 2025
Copy link

netlify bot commented Jun 26, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit e2b6f0b
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/685db8dc18c0d0000876ac0b
😎 Deploy Preview https://deploy-preview-39735--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

coderabbitai bot commented Jun 26, 2025

📝 Walkthrough

Walkthrough

The documentation for the Rehlko integration was updated to add the Kohler 30RCL generator model to the list of tested generators, including a link to its product page. No code, logic, or control flow changes were made.

Changes

Files Change Summary
source/_integrations/rehlko.markdown Added Kohler 30RCL to tested generators list

Sequence Diagram(s)

(No sequence diagram generated as the changes are documentation-only.)

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Add Kohler 30RCL as tested generator (#39595)

Assessment against linked issues: Out-of-scope changes

(No out-of-scope changes found.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_integrations/rehlko.markdown (1)

101-109: Optional: keep the “Tested generators” list ordered for quick scanning

The bullet list is now 38 → 26 → 20 → 20 → 14 → 30, which feels random. Consider ordering numerically (descending or ascending) or alphabetically for easier maintenance.

Purely cosmetic—no functional impact.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between f03bf01 and e2b6f0b.

📒 Files selected for processing (1)
  • source/_integrations/rehlko.markdown (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`source/_integrations/*`: Integration documentation must use the provided template structure and section order.

source/_integrations/*: Integration documentation must use the provided template structure and section order.

📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)

List of files the instruction was applied to:

  • source/_integrations/rehlko.markdown
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/rehlko.markdown (1)

108-108: Model/link mismatch – please verify generator identifier

The list item shows 30RCL, but the linked URL ends with 30rcla. That extra “A” denotes a different model (30RCLA). Either the text or the link (or both) needs to be corrected to avoid confusing readers.

- - [30RCL](https://www.kohlerhomeenergy.rehlko.com/products/home+generators/30rcla)
+ - [30RCLA](https://www.kohlerhomeenergy.rehlko.com/products/home+generators/30rcla)

If you truly mean the non-“A” variant, update the URL to the exact 30RCL page instead.

@frenck frenck requested a review from Copilot June 26, 2025 21:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the Kohler 30RCL model to the list of generators tested with the Rehlko integration.

  • Included the 30RCL series in the tested generators section.
Comments suppressed due to low confidence (1)

source/_integrations/rehlko.markdown:108

  • [nitpick] The display name 30RCL does not match the URL suffix 30rcla. Consider updating the link text to 30RCL-A (if the model includes the ‘A’ suffix) or removing the trailing ‘a’ in the URL to keep them consistent.
- [30RCL](https://www.kohlerhomeenergy.rehlko.com/products/home+generators/30rcla)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @PeteRager 👍

../Frenck

@frenck frenck merged commit f259a6a into home-assistant:current Jun 27, 2025
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Works with Kohler 30RCL
2 participants