-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Z-Wave: change caution into note/notice #39720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the Z-Wave documentation to change caution messages into note/notice messages in order to partially comply with ANSI guidelines when documenting hazards.
- Changed the block directive from {% caution %} to {% note %}.
- Updated the inline bullet text from Caution to Notice.
Comments suppressed due to low confidence (2)
source/_integrations/zwave_js.markdown:235
- [nitpick] Changing the directive from {% caution %} to {% note %} alters the perceived risk level; consider reviewing the message content to ensure it accurately reflects the intended level of hazard when notifying the user.
{% note %}
source/_integrations/zwave_js.markdown:257
- [nitpick] The inline bullet text has been updated from 'Caution' to 'Notice'; verify that the revised wording maintains an appropriate emphasis on the potential risk during a firmware update.
- **Notice: Risk of damage to the device**
📝 WalkthroughWalkthroughThe documentation for Z-Wave device firmware updates was revised to soften the risk warning language. The caution block and inline warning were both changed to notes, but the content and procedural instructions remain unchanged. Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to documentation wording. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/zwave_js.markdown (1)
257-262
: Over-nested list may render awkwardly – consider flatteningThe current 3-level bullet hierarchy can produce overly indented text (Markdown → HTML list-in-list-in-list).
Flattening to two levels keeps the warning readable while avoiding style glitches in some themes.- - **Notice: Risk of damage to the device** - - Make sure you select the correct firmware file. - - An incorrect firmware file can damage your device. - - Once you start the update process, you must wait for the update to complete. - - An interrupted update can damage your device. + - **Notice: Risk of damage to the device** + - Make sure you select the correct firmware file. An incorrect file can damage your device. + - Once you start the update process, wait for it to complete. Interrupting the update can damage your device.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
Gemfile.lock
is excluded by!**/*.lock
📒 Files selected for processing (1)
source/_integrations/zwave_js.markdown
(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`source/_integrations/*`: Integration documentation must use the provided template structure and section order.
source/_integrations/*
: Integration documentation must use the provided template structure and section order.
📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)
List of files the instruction was applied to:
source/_integrations/zwave_js.markdown
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/zwave_js.markdown (1)
235-244
: Confirm the downgrade from{% caution %}
to{% note %}
is acceptable
{% note %}
is normally used for purely informational call-outs, whereas the content here still communicates a tangible risk of device damage.
Please double-check with the docs style guide / Z-Wave maintainers that this demotion in severity is intentional and does not reduce the visual prominence that was originally deemed necessary.
1ab9d40
to
241effa
Compare
thanks! |
Proposed change
Z-Wave: change caution into note/notice
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit