Skip to content

Add exclude entities params to area card #39710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025
Merged

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Jun 25, 2025

Proposed change

Adds two new parameters for the area card :

  • color
  • exclude_entities

Remove one parameter for the area card :

  • theme

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated Area card documentation to remove deprecated theme option and related links.
    • Added details for new optional color configuration, including a list of available color tokens.
    • Introduced documentation for the new exclude_entities option to filter out specific entities.
    • Clarified default value for display_type and updated YAML examples accordingly.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jun 25, 2025
Copy link

netlify bot commented Jun 25, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit cf4d91c
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/685c0c7bd983d500083fc830
😎 Deploy Preview https://deploy-preview-39710--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@piitaya piitaya force-pushed the area_card_exclude_entities branch from 47e6db8 to 8132e7c Compare June 25, 2025 14:24
@piitaya piitaya added the parent-merged The parent PR has been merged already label Jun 25, 2025
@piitaya piitaya marked this pull request as ready for review June 25, 2025 14:34
@Copilot Copilot AI review requested due to automatic review settings June 25, 2025 14:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation for the Area card by adding two new parameters—color and exclude_entities—and removing the theme parameter to reflect upcoming feature changes.

  • Added a new optional color parameter to customize the icon and hover/focus state.
  • Added a new optional exclude_entities parameter to filter out specific entities from the card.
  • Removed the theme parameter.
Comments suppressed due to low confidence (1)

source/_dashboards/area.markdown:85

  • [nitpick] Consider clarifying in the description how the list provided in the exclude_entities parameter is used. This could include a note on the behavior when an empty list is supplied.
exclude_entities:

Add color and drop theme option

Add color and drop theme option

Undo gem changes
@piitaya piitaya force-pushed the area_card_exclude_entities branch from 668e2ce to 8e3703e Compare June 25, 2025 14:36
Copy link
Contributor

coderabbitai bot commented Jun 25, 2025

📝 Walkthrough

Walkthrough

The documentation for the Area card was updated to reflect recent changes: the deprecated theme option and its related documentation link were removed. New configuration options color and exclude_entities were introduced, and the default for display_type was set to "picture." Example YAML and a color tokens reference section were also updated.

Changes

File Change Summary
source/_dashboards/area.markdown Removed theme references and related docs link; added color and exclude_entities options; set display_type default; updated example YAML; added color tokens section.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AreaCardDoc

    User->>AreaCardDoc: Reads Area card documentation
    AreaCardDoc-->>User: Presents updated options (color, exclude_entities, display_type)
    User->>AreaCardDoc: References color tokens section for valid values
Loading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
source/_dashboards/area.markdown (4)

43-47: Tighten link + wording for the new color option

Small copy-editing tweaks will improve clarity and future-proof the link:

-  description: Set the color for the icon and the hover/focus state. It accepts [color token](/dashboards/area/#available-colors) or hex color code.
+  description: Set the color for the icon and its hover/focus states. Accepts a [color token](#available-colors) or a hex color code.

• Keeps wording consistent with plural “states”.
• Uses an in-page anchor instead of a hard-coded path, so the link survives any URL restructures.


85-88: Add article + Oxford comma for smoother reading

-  description: A list of entities that will be excluded from the card. It will affect sensor_classes, alert_classes and features.
+  description: A list of entities that will be excluded from the card. It will affect the `sensor_classes`, `alert_classes`, and `features`.

Minor grammar/readability polish; no content change.


105-115: Showcase the new options in the “Complex example”

Since this block is meant to demonstrate advanced usage, consider including the newly-added color and exclude_entities properties so readers instantly see them in context:

   area: bedroom
   display_type: picture
   navigation_path: my_bedroom
+  color: indigo
   sensor_classes: 
     - temperature
     - humidity
   alert_classes:
     - moisture
     - motion
   features:
     - type: area-controls
+  exclude_entities:
+    - light.bedroom_lamp

Helps users adopt the new features without hunting through docs.


117-119: Light grammar touch-up in “Available colors” header

-You want to colorize the area card? Choose one of the following colors:
+Want to colorize the area card? Choose one of the following colors:

Removes an extra auxiliary verb for smoother phrasing.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between cfdef08 and 668e2ce.

⛔ Files ignored due to path filters (1)
  • Gemfile.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • source/_dashboards/area.markdown (3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_dashboards/area.markdown

[grammar] ~118-~118: It seems that an auxiliary verb is missing at the beginning of this question.
Context: ...area-controls ``` ## Available colors You want to colorize the area card? Choose ...

(PRP_VB_QUESTION)

@piitaya piitaya marked this pull request as draft June 25, 2025 14:37
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
source/_dashboards/area.markdown (4)

43-47: Polish wording + give a concrete example for color

Minor copy-editing makes the sentence flow better and an inline example clarifies the expected value format.

-color:
-  required: false
-  description: Set the color for the icon and the hover/focus state. It accepts [color token](/dashboards/area/#available-colors) or hex color code.
-  type: string
+color:
+  required: false
+  description: Set the color of the icon and its hover/focus state. Accepts a [color token](/dashboards/area/#available-colors) or a hex color code (e.g., `#FF0000`).
+  type: string

85-88: Tighten description of exclude_entities

Shorter wording and code-style formatting improve readability.

-exclude_entities:
-  required: false
-  description: A list of entities that will be excluded from the card. It will affect sensor_classes, alert_classes and features.
-  type: list
+exclude_entities:
+  required: false
+  description: List of entities to hide from this card. Applies to `sensor_classes`, `alert_classes`, and `features`.
+  type: list

105-115: Extend complex example to showcase the new parameters

Including the freshly documented color and exclude_entities makes the example self-contained and demonstrates typical usage.

 type: area
 area: bedroom
 display_type: picture
+color: teal
 navigation_path: my_bedroom
 sensor_classes: 
   - temperature
   - humidity
 alert_classes:
   - moisture
   - motion
 features:
   - type: area-controls
+exclude_entities:
+  - switch.bedroom_lamp

117-119: Grammar & punctuation tweak in “Available colors” section

-You want to colorize the area card? Choose one of the following colors: `primary`, `accent`, `disabled`, `red`, `pink`, `purple`, `deep-purple`, `indigo`, `blue`, `light-blue`, `cyan`, `teal`, `green`, `light-green`, `lime`, `yellow`, `amber`, `orange`, `deep-orange`, `brown`, `grey`, `blue-grey`, `black` and `white`.
+To colorize the area card, choose one of the following color tokens: `primary`, `accent`, `disabled`, `red`, `pink`, `purple`, `deep-purple`, `indigo`, `blue`, `light-blue`, `cyan`, `teal`, `green`, `light-green`, `lime`, `yellow`, `amber`, `orange`, `deep-orange`, `brown`, `grey`, `blue-grey`, `black`, or `white`.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 668e2ce and 8e3703e.

⛔ Files ignored due to path filters (1)
  • Gemfile.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • source/_dashboards/area.markdown (3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_dashboards/area.markdown

[grammar] ~118-~118: It seems that an auxiliary verb is missing at the beginning of this question.
Context: ...area-controls ``` ## Available colors You want to colorize the area card? Choose ...

(PRP_VB_QUESTION)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

@piitaya piitaya added this to the 2025.7 milestone Jun 25, 2025
@piitaya piitaya marked this pull request as ready for review June 25, 2025 14:38
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @piitaya 👍

@c0ffeeca7 c0ffeeca7 enabled auto-merge (squash) June 25, 2025 14:49
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
source/_dashboards/area.markdown (3)

43-46: Minor grammar tweak for color description
Add an article before “color token” and keep parallel structure for clarity.

-  description: Set the color for the icon and the hover/focus state. It accepts [color token](/dashboards/area/#available-colors) or hex color code.
+  description: Set the color for the icon and the hover/focus state. It accepts a [color token](/dashboards/area/#available-colors) or a hex color code.

85-88: Streamline wording of exclude_entities description
Using the simple present makes the sentence shorter and clearer.

-  description: A list of entities that will be excluded from the card. It will affect sensor_classes, alert_classes, and features.
+  description: A list of entities to exclude from the card. This affects `sensor_classes`, `alert_classes`, and `features`.

117-119: Fix awkward question phrasing in “Available colors” section
LanguageTool flagged the missing auxiliary verb; dropping it reads better in documentation.

-You want to colorize the area card? Choose one of the following colors: `primary`, `accent`, `disabled`, `red`, `pink`, `purple`, `deep-purple`, `indigo`, `blue`, `light-blue`, `cyan`, `teal`, `green`, `light-green`, `lime`, `yellow`, `amber`, `orange`, `deep-orange`, `brown`, `grey`, `blue-grey`, `black`, and `white`.
+Want to colorize the area card? Choose one of the following colors: `primary`, `accent`, `disabled`, `red`, `pink`, `purple`, `deep-purple`, `indigo`, `blue`, `light-blue`, `cyan`, `teal`, `green`, `light-green`, `lime`, `yellow`, `amber`, `orange`, `deep-orange`, `brown`, `grey`, `blue-grey`, `black`, and `white`.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 8e3703e and cf4d91c.

📒 Files selected for processing (1)
  • source/_dashboards/area.markdown (3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_dashboards/area.markdown

[grammar] ~118-~118: It seems that an auxiliary verb is missing at the beginning of this question.
Context: ...area-controls ``` ## Available colors You want to colorize the area card? Choose ...

(PRP_VB_QUESTION)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

@c0ffeeca7 c0ffeeca7 merged commit 61a9364 into next Jun 25, 2025
9 checks passed
@c0ffeeca7 c0ffeeca7 deleted the area_card_exclude_entities branch June 25, 2025 16:52
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Jun 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2025
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants