Skip to content

Update ESPHome entity_id docs for unicode chars #39704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 25, 2025

Proposed change

Update ESPHome entity_id docs for unicode chars

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Clarified how Unicode characters in entity names and IDs are handled for the ESPHome integration.
    • Added an example showing transliteration of Unicode characters to ASCII equivalents in entity IDs.

@Copilot Copilot AI review requested due to automatic review settings June 25, 2025 11:09
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jun 25, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ESPHome integration documentation to explain how Unicode characters are handled when generating entity IDs and adds an illustrative example.

  • Added a bullet point describing transliteration of Unicode characters to ASCII.
  • Provided a YAML example showing accented characters and how they become ASCII-only in the resulting entity ID.
Comments suppressed due to low confidence (1)

source/_integrations/esphome.markdown:155

  • Consider clarifying that punctuation and certain symbols (such as hyphens or spaces) are also normalized to underscores after transliteration, so readers understand which characters are transliterated versus replaced.
- Unicode characters in names are transliterated to their closest ASCII equivalents for compatibility

Copy link

netlify bot commented Jun 25, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 5ce4b3a
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/685bd8d231530e00083c3dc7
😎 Deploy Preview https://deploy-preview-39704--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

coderabbitai bot commented Jun 25, 2025

📝 Walkthrough

Walkthrough

The ESPHome integration documentation was updated to clarify how Unicode characters in entity names and IDs are handled. Specifically, it now states that Unicode characters are transliterated to their closest ASCII equivalents, and it provides an example illustrating this behavior.

Changes

File Change Summary
source/_integrations/esphome.markdown Updated documentation to explain Unicode handling in entity names/IDs and added a relevant example.

Sequence Diagram(s)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_integrations/esphome.markdown (1)

182-194: Minor YAML-format tweak improves accuracy

ESPHome examples normally model sensor: as a list item. Switching to the list form (using a dash and 2-space indentation) keeps the sample syntactically identical to real-world configs and avoids user copy-paste surprises.

-sensor:
-   name: "Árvíztűrő tükörfúrógép"
+sensor:
+  - name: "Árvíztűrő tükörfúrógép"
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between f11446a and 5ce4b3a.

📒 Files selected for processing (1)
  • source/_integrations/esphome.markdown (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`source/_integrations/*`: Integration documentation must use the provided template structure and section order.

source/_integrations/*: Integration documentation must use the provided template structure and section order.

📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)

List of files the instruction was applied to:

  • source/_integrations/esphome.markdown
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/esphome.markdown (1)

153-156: Bullet addition looks good

The new note about Unicode transliteration is clear, consistent with the preceding bullets (no trailing period) and fits naturally in this section.

@home-assistant home-assistant bot added the parent-merged The parent PR has been merged already label Jun 25, 2025
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bdraco 👍

@c0ffeeca7 c0ffeeca7 merged commit 28f3589 into next Jun 25, 2025
9 checks passed
@c0ffeeca7 c0ffeeca7 deleted the esphome_entity_id_change branch June 25, 2025 11:38
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Jun 25, 2025
@bdraco
Copy link
Member Author

bdraco commented Jun 25, 2025

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants