-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Update ESPHome entity_id docs for unicode chars #39704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the ESPHome integration documentation to explain how Unicode characters are handled when generating entity IDs and adds an illustrative example.
- Added a bullet point describing transliteration of Unicode characters to ASCII.
- Provided a YAML example showing accented characters and how they become ASCII-only in the resulting entity ID.
Comments suppressed due to low confidence (1)
source/_integrations/esphome.markdown:155
- Consider clarifying that punctuation and certain symbols (such as hyphens or spaces) are also normalized to underscores after transliteration, so readers understand which characters are transliterated versus replaced.
- Unicode characters in names are transliterated to their closest ASCII equivalents for compatibility
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe ESPHome integration documentation was updated to clarify how Unicode characters in entity names and IDs are handled. Specifically, it now states that Unicode characters are transliterated to their closest ASCII equivalents, and it provides an example illustrating this behavior. Changes
Sequence Diagram(s)Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/esphome.markdown (1)
182-194
: Minor YAML-format tweak improves accuracyESPHome examples normally model
sensor:
as a list item. Switching to the list form (using a dash and 2-space indentation) keeps the sample syntactically identical to real-world configs and avoids user copy-paste surprises.-sensor: - name: "Árvíztűrő tükörfúrógép" +sensor: + - name: "Árvíztűrő tükörfúrógép"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/esphome.markdown
(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`source/_integrations/*`: Integration documentation must use the provided template structure and section order.
source/_integrations/*
: Integration documentation must use the provided template structure and section order.
📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)
List of files the instruction was applied to:
source/_integrations/esphome.markdown
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/esphome.markdown (1)
153-156
: Bullet addition looks goodThe new note about Unicode transliteration is clear, consistent with the preceding bullets (no trailing period) and fits naturally in this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @bdraco 👍
Thanks! |
Proposed change
Update ESPHome entity_id docs for unicode chars
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit