Skip to content

Document max_sub_interval for derivative #39690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025
Merged

Document max_sub_interval for derivative #39690

merged 3 commits into from
Jun 24, 2025

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Jun 24, 2025

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated Derivative integration documentation to include the new "Max sub-interval" configuration option, explaining its effect and usage in both the feature overview and YAML configuration sections.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jun 24, 2025
Copy link

netlify bot commented Jun 24, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 57ca52b
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/685aa0dbaab3d1000843f8be
😎 Deploy Preview https://deploy-preview-39690--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

coderabbitai bot commented Jun 24, 2025

📝 Walkthrough

"""

Walkthrough

The documentation for the Derivative integration was updated to introduce and describe a new configuration option, "max_sub_interval." This option allows the derivative calculation to be triggered if a specified time duration passes without updates from the source sensor. The option is detailed in both the configuration overview and YAML schema.

Changes

File Change Summary
source/_integrations/derivative.markdown Added documentation for the new max_sub_interval configuration option in multiple sections

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DerivativeIntegration
    participant SourceSensor

    Note over User,DerivativeIntegration: Configuration phase
    User->>DerivativeIntegration: Set max_sub_interval (optional)

    Note over SourceSensor,DerivativeIntegration: Runtime
    SourceSensor-->>DerivativeIntegration: Sensor update
    DerivativeIntegration->>DerivativeIntegration: Recalculate derivative

    alt No update within max_sub_interval
        DerivativeIntegration->>DerivativeIntegration: Recalculate derivative after max_sub_interval
    end
Loading

"""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 7376c5a and 57ca52b.

📒 Files selected for processing (1)
  • source/_integrations/derivative.markdown (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • source/_integrations/derivative.markdown
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
source/_integrations/derivative.markdown (1)

91-95: Align field-property order with existing pattern

For every option above (time_window, unit_time, etc.) the order is
description, default, required, type.
Keeping the same order helps readability and avoids accidental lint failures.

 max_sub_interval:
   description: Normally the derivative is calculated each time the source sensor updates. If a time is specified for this option, the derivative will also be recalculated if this amount of time elapses without an update of the source sensor.
-  required: false
-  type: time
-  default: 0  
+  default: 0
+  required: false
+  type: time

(While touching the lines, the trailing double-space after 0 has been removed.)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 4ef6cc4 and 834c3d2.

📒 Files selected for processing (1)
  • source/_integrations/derivative.markdown (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`source/_integrations/*`: Integration documentation must use the provided template structure and section order.

source/_integrations/*: Integration documentation must use the provided template structure and section order.

  • source/_integrations/derivative.markdown
🪛 LanguageTool
source/_integrations/derivative.markdown

[uncategorized] ~92-~92: Possible missing comma found.
Context: ...: time max_sub_interval: description: Normally the derivative is calculated each time ...

(AI_HYDRA_LEO_MISSING_COMMA)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
source/_integrations/derivative.markdown (2)

40-41: Minor grammar tweak for readability
The sentence is a bit long; inserting a comma after the introductory clause improves flow and mirrors the style used in other option descriptions.

-  description: Normally the derivative is calculated each time the source sensor updates. If a time is specified for this option, the derivative will also be recalculated if this amount of time elapses without an update of the source sensor.
+  description: Normally, the derivative is calculated each time the source sensor updates. If a time is specified for this option, the derivative will also be recalculated if this amount of time elapses without an update of the source sensor.

91-95: Trim trailing whitespace in YAML-schema block
Line 95 contains two trailing spaces after the 0. These will be flagged by the docs linter and should be removed.

-  default: 0  
+  default: 0
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 834c3d2 and 7376c5a.

📒 Files selected for processing (1)
  • source/_integrations/derivative.markdown (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`source/_integrations/*`: Integration documentation must use the provided template structure and section order.

source/_integrations/*: Integration documentation must use the provided template structure and section order.

  • source/_integrations/derivative.markdown
🪛 LanguageTool
source/_integrations/derivative.markdown

[uncategorized] ~41-~41: Possible missing comma found.
Context: ...meter. Max sub-interval: description: Normally the derivative is calculated each time ...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~92-~92: Possible missing comma found.
Context: ...: time max_sub_interval: description: Normally the derivative is calculated each time ...

(AI_HYDRA_LEO_MISSING_COMMA)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

@home-assistant home-assistant bot added the parent-merged The parent PR has been merged already label Jun 24, 2025
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @karwosts 👍

@c0ffeeca7 c0ffeeca7 merged commit 0af34ac into next Jun 24, 2025
9 checks passed
@c0ffeeca7 c0ffeeca7 deleted the karwosts-patch-2 branch June 24, 2025 14:17
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Jun 24, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants