-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Add Documentation for Manual Charge Switch for Kostal Plenticore #39573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe documentation for the Kostal Plenticore integration was updated to correct formatting in the installer access warning and to add a new "Battery Manual Charge" sensor. This sensor, accessible only with installer credentials, allows manual charging of the battery to 100%, and is documented with appropriate cautionary notes. Changes
Sequence Diagram(s)sequenceDiagram
User -> Documentation: Reads about installer access
User -> Documentation: Finds "Battery Manual Charge" sensor
Documentation -> User: Informs about sensor and installer-only access
User -> Integration: Uses installer credentials to access sensor
Integration -> Battery System: Initiates manual charge to 100%
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/kostal_plenticore.markdown (3)
33-38
: Ensure warning bullets are full sentences with consistent punctuation
The items under the warning block read as fragments and lack a clear subject. Rewrite them as complete or imperative sentences and add periods for consistency:{% warning %} Using installer credentials: - - Should only be done if you fully understand the implications - - May void your warranty - - Could potentially damage your device if settings are incorrectly configured - - Should be done with extreme caution + - Only use installer credentials if you fully understand the implications. + - This may void your warranty. + - Incorrect settings can potentially damage your device. + - Use with extreme caution. {% endwarning %}🧰 Tools
🪛 LanguageTool
[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...(MISSING_IT_THERE)
[uncategorized] ~36-~36: A period might be missing here.
Context: ...onfigured - Should be done with extreme caution {% endwarning %} To enable installer ...(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)
173-178
: Clarify the new sensor description in the table
The table entry for Battery Manual Charge should indicate it forces a full (100%) charge to align with the detailed description:-| Battery Manual Charge | | RW | Force the battery to charge. | +| Battery Manual Charge | | RW | Force the battery to charge to 100%. |
197-202
: Improve grammar and remove redundancy in the detailed section
The current phrasing is awkward and repeats “using installer access.” Revise as follows for clarity:#### Battery Manual Charge -The Battery Manual Charge sensor allows to force charge the battery to 100% regardless of PV generation or home usage. -This setting is available when using installer access and should therefore only be used with the same caution as using installer access. -More on [Installer Access](#installer-access) +The Battery Manual Charge sensor allows you to force the battery to charge to 100%, regardless of PV generation or home usage. +This setting is only available when using installer access, and should therefore be used with the same caution. +More on [Installer Access](#installer-access).🧰 Tools
🪛 LanguageTool
[grammar] ~199-~199: Did you mean “forcing”? Or maybe you should add a pronoun? In active voice, ‘allow’ + ‘to’ takes an object, usually a pronoun.
Context: ...The Battery Manual Charge sensor allows to force charge the battery to 100% regardless o...(ALLOW_TO)
[uncategorized] ~200-~200: Possible missing comma found.
Context: ...tting is available when using installer access and should therefore only be used with ...(AI_HYDRA_LEO_MISSING_COMMA)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/kostal_plenticore.markdown
(3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/kostal_plenticore.markdown
[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...
(MISSING_IT_THERE)
[uncategorized] ~36-~36: A period might be missing here.
Context: ...onfigured - Should be done with extreme caution {% endwarning %} To enable installer ...
(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)
[grammar] ~199-~199: Did you mean “forcing”? Or maybe you should add a pronoun? In active voice, ‘allow’ + ‘to’ takes an object, usually a pronoun.
Context: ...The Battery Manual Charge sensor allows to force charge the battery to 100% regardless o...
(ALLOW_TO)
[uncategorized] ~200-~200: Possible missing comma found.
Context: ...tting is available when using installer access and should therefore only be used with ...
(AI_HYDRA_LEO_MISSING_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Lint Markdown
- GitHub Check: Pages changed - home-assistant-docs
📝 WalkthroughWalkthroughThe documentation for the Kostal Plenticore integration was updated to add information about the new "Battery Manual Charge" sensor, clarify that it is only available with installer access, and improve formatting consistency in the installer access warning section. No changes were made to the integration logic or configuration. Changes
Sequence Diagram(s)No sequence diagram generated, as the changes are limited to documentation updates. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/kostal_plenticore.markdown (1)
199-202
: Refine phrasing and grammar for clarity
- Change “allows to force charge” to “allows you to force the battery to charge”
- Avoid repeating “using installer access” by rephrasing for brevity
Example diff:
-The Battery Manual Charge sensor allows to force charge the battery to 100% regardless of PV generation or home usage. -This setting is available when using installer access and should therefore only be used with the same caution as using installer access. +The Battery Manual Charge sensor allows you to force the battery to charge to 100%, regardless of PV generation or home usage. +This setting is only available with installer access and should be used with the same caution as other installer-level operations.🧰 Tools
🪛 LanguageTool
[grammar] ~199-~199: Did you mean “forcing”? Or maybe you should add a pronoun? In active voice, ‘allow’ + ‘to’ takes an object, usually a pronoun.
Context: ...The Battery Manual Charge sensor allows to force charge the battery to 100% regardless o...(ALLOW_TO)
[uncategorized] ~200-~200: Possible missing comma found.
Context: ...tting is available when using installer access and should therefore only be used with ...(AI_HYDRA_LEO_MISSING_COMMA)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/kostal_plenticore.markdown
(3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/kostal_plenticore.markdown
[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...
(MISSING_IT_THERE)
[uncategorized] ~36-~36: A period might be missing here.
Context: ...onfigured - Should be done with extreme caution {% endwarning %} To enable installer ...
(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)
[grammar] ~199-~199: Did you mean “forcing”? Or maybe you should add a pronoun? In active voice, ‘allow’ + ‘to’ takes an object, usually a pronoun.
Context: ...The Battery Manual Charge sensor allows to force charge the battery to 100% regardless o...
(ALLOW_TO)
[uncategorized] ~200-~200: Possible missing comma found.
Context: ...tting is available when using installer access and should therefore only be used with ...
(AI_HYDRA_LEO_MISSING_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (3)
source/_integrations/kostal_plenticore.markdown (3)
33-36
: Good removal of trailing spaces and formatting consistencyThe warning list items have been cleaned of trailing spaces and maintain clear formatting.
🧰 Tools
🪛 LanguageTool
[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...(MISSING_IT_THERE)
[uncategorized] ~36-~36: A period might be missing here.
Context: ...onfigured - Should be done with extreme caution {% endwarning %} To enable installer ...(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)
40-40
: Clear instruction for enabling installer accessThe new sentence concisely explains how to set up installer access in the configuration.
173-178
: Correct addition of new sensor in settings tableThe new "Battery Manual Charge" entry is properly formatted in the settings sensors table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Schlauer-Hax 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/kostal_plenticore.markdown (1)
197-202
: Tighten wording & remove redundancy in installer-access caution sentenceLine 200 repeats “using installer access” and misses a comma, which the linter flagged. A crisper version keeps the warning while avoiding duplication:
-The Battery Manual Charge sensor allows you to force charge the battery to 100%, regardless of PV generation or home usage. -This setting is available when using installer access and should therefore only be used with the same caution as using installer access. -More on [Installer Access](#installer-access) +The Battery Manual Charge sensor allows you to force-charge the battery to 100 %, regardless of PV generation or home usage. +This setting is available when installer access is enabled, and should therefore be used with the same caution. +More on [Installer Access](#installer-access)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/kostal_plenticore.markdown
(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`source/_integrations/*`: Integration documentation must use the provided template structure and section order.
source/_integrations/*
: Integration documentation must use the provided template structure and section order.
📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)
List of files the instruction was applied to:
source/_integrations/kostal_plenticore.markdown
🪛 LanguageTool
source/_integrations/kostal_plenticore.markdown
[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...
(MISSING_IT_THERE)
[uncategorized] ~200-~200: Possible missing comma found.
Context: ...tting is available when using installer access and should therefore only be used with ...
(AI_HYDRA_LEO_MISSING_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/kostal_plenticore.markdown (2)
33-36
: Consider collapsing overlapping bullet pointsBullets 1 and 4 both tell the reader to proceed only if fully aware/with caution.
Merging them avoids repetition and shortens the list without losing information.[ suggest_nitpick ]
173-178
: Sensor table addition looks consistent with templateHeader alignment, column order, and “RW” flag all match the style used above. No issues spotted.
Proposed change
Adds documentation for the proposed change in home-assistant/core#146932
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit