Skip to content

Add Documentation for Manual Charge Switch for Kostal Plenticore #39573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025

Conversation

Schlauer-Hax
Copy link
Contributor

@Schlauer-Hax Schlauer-Hax commented Jun 16, 2025

Proposed change

Adds documentation for the proposed change in home-assistant/core#146932

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated formatting for installer access warning list items.
    • Added information about the new "Battery Manual Charge" sensor, including usage details and access requirements.
    • Linked the installer access note for easier reference.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jun 16, 2025
Copy link

netlify bot commented Jun 16, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 5d411b8
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/685e2ba1c0bc460008a8e926
😎 Deploy Preview https://deploy-preview-39573--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

coderabbitai bot commented Jun 16, 2025

📝 Walkthrough

Walkthrough

The documentation for the Kostal Plenticore integration was updated to correct formatting in the installer access warning and to add a new "Battery Manual Charge" sensor. This sensor, accessible only with installer credentials, allows manual charging of the battery to 100%, and is documented with appropriate cautionary notes.

Changes

File Change Summary
source/_integrations/kostal_plenticore.markdown Fixed formatting in installer access warning; added "Battery Manual Charge" sensor and description.

Sequence Diagram(s)

sequenceDiagram
    User -> Documentation: Reads about installer access
    User -> Documentation: Finds "Battery Manual Charge" sensor
    Documentation -> User: Informs about sensor and installer-only access
    User -> Integration: Uses installer credentials to access sensor
    Integration -> Battery System: Initiates manual charge to 100%
Loading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
source/_integrations/kostal_plenticore.markdown (3)

33-38: Ensure warning bullets are full sentences with consistent punctuation
The items under the warning block read as fragments and lack a clear subject. Rewrite them as complete or imperative sentences and add periods for consistency:

 {% warning %}
 Using installer credentials:
- - Should only be done if you fully understand the implications
- - May void your warranty
- - Could potentially damage your device if settings are incorrectly configured
- - Should be done with extreme caution
+ - Only use installer credentials if you fully understand the implications.
+ - This may void your warranty.
+ - Incorrect settings can potentially damage your device.
+ - Use with extreme caution.
 {% endwarning %}
🧰 Tools
🪛 LanguageTool

[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...

(MISSING_IT_THERE)


[uncategorized] ~36-~36: A period might be missing here.
Context: ...onfigured - Should be done with extreme caution {% endwarning %} To enable installer ...

(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)


173-178: Clarify the new sensor description in the table
The table entry for Battery Manual Charge should indicate it forces a full (100%) charge to align with the detailed description:

-| Battery Manual Charge   |      | RW | Force the battery to charge. |
+| Battery Manual Charge   |      | RW | Force the battery to charge to 100%. |

197-202: Improve grammar and remove redundancy in the detailed section
The current phrasing is awkward and repeats “using installer access.” Revise as follows for clarity:

#### Battery Manual Charge

-The Battery Manual Charge sensor allows to force charge the battery to 100% regardless of PV generation or home usage.
-This setting is available when using installer access and should therefore only be used with the same caution as using installer access.
-More on [Installer Access](#installer-access)
+The Battery Manual Charge sensor allows you to force the battery to charge to 100%, regardless of PV generation or home usage.
+This setting is only available when using installer access, and should therefore be used with the same caution.
+More on [Installer Access](#installer-access).
🧰 Tools
🪛 LanguageTool

[grammar] ~199-~199: Did you mean “forcing”? Or maybe you should add a pronoun? In active voice, ‘allow’ + ‘to’ takes an object, usually a pronoun.
Context: ...The Battery Manual Charge sensor allows to force charge the battery to 100% regardless o...

(ALLOW_TO)


[uncategorized] ~200-~200: Possible missing comma found.
Context: ...tting is available when using installer access and should therefore only be used with ...

(AI_HYDRA_LEO_MISSING_COMMA)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between ae22660 and 832b420.

📒 Files selected for processing (1)
  • source/_integrations/kostal_plenticore.markdown (3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/kostal_plenticore.markdown

[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...

(MISSING_IT_THERE)


[uncategorized] ~36-~36: A period might be missing here.
Context: ...onfigured - Should be done with extreme caution {% endwarning %} To enable installer ...

(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)


[grammar] ~199-~199: Did you mean “forcing”? Or maybe you should add a pronoun? In active voice, ‘allow’ + ‘to’ takes an object, usually a pronoun.
Context: ...The Battery Manual Charge sensor allows to force charge the battery to 100% regardless o...

(ALLOW_TO)


[uncategorized] ~200-~200: Possible missing comma found.
Context: ...tting is available when using installer access and should therefore only be used with ...

(AI_HYDRA_LEO_MISSING_COMMA)

⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Lint Markdown
  • GitHub Check: Pages changed - home-assistant-docs

Copy link
Contributor

coderabbitai bot commented Jun 16, 2025

📝 Walkthrough

Walkthrough

The documentation for the Kostal Plenticore integration was updated to add information about the new "Battery Manual Charge" sensor, clarify that it is only available with installer access, and improve formatting consistency in the installer access warning section. No changes were made to the integration logic or configuration.

Changes

File Change Summary
source/_integrations/kostal_plenticore.markdown Added documentation for "Battery Manual Charge" sensor, updated installer access warnings, improved formatting.

Sequence Diagram(s)

No sequence diagram generated, as the changes are limited to documentation updates.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_integrations/kostal_plenticore.markdown (1)

199-202: Refine phrasing and grammar for clarity

  • Change “allows to force charge” to “allows you to force the battery to charge”
  • Avoid repeating “using installer access” by rephrasing for brevity

Example diff:

-The Battery Manual Charge sensor allows to force charge the battery to 100% regardless of PV generation or home usage.
-This setting is available when using installer access and should therefore only be used with the same caution as using installer access.
+The Battery Manual Charge sensor allows you to force the battery to charge to 100%, regardless of PV generation or home usage.
+This setting is only available with installer access and should be used with the same caution as other installer-level operations.
🧰 Tools
🪛 LanguageTool

[grammar] ~199-~199: Did you mean “forcing”? Or maybe you should add a pronoun? In active voice, ‘allow’ + ‘to’ takes an object, usually a pronoun.
Context: ...The Battery Manual Charge sensor allows to force charge the battery to 100% regardless o...

(ALLOW_TO)


[uncategorized] ~200-~200: Possible missing comma found.
Context: ...tting is available when using installer access and should therefore only be used with ...

(AI_HYDRA_LEO_MISSING_COMMA)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between ae22660 and 832b420.

📒 Files selected for processing (1)
  • source/_integrations/kostal_plenticore.markdown (3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/kostal_plenticore.markdown

[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...

(MISSING_IT_THERE)


[uncategorized] ~36-~36: A period might be missing here.
Context: ...onfigured - Should be done with extreme caution {% endwarning %} To enable installer ...

(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)


[grammar] ~199-~199: Did you mean “forcing”? Or maybe you should add a pronoun? In active voice, ‘allow’ + ‘to’ takes an object, usually a pronoun.
Context: ...The Battery Manual Charge sensor allows to force charge the battery to 100% regardless o...

(ALLOW_TO)


[uncategorized] ~200-~200: Possible missing comma found.
Context: ...tting is available when using installer access and should therefore only be used with ...

(AI_HYDRA_LEO_MISSING_COMMA)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (3)
source/_integrations/kostal_plenticore.markdown (3)

33-36: Good removal of trailing spaces and formatting consistency

The warning list items have been cleaned of trailing spaces and maintain clear formatting.

🧰 Tools
🪛 LanguageTool

[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...

(MISSING_IT_THERE)


[uncategorized] ~36-~36: A period might be missing here.
Context: ...onfigured - Should be done with extreme caution {% endwarning %} To enable installer ...

(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)


40-40: Clear instruction for enabling installer access

The new sentence concisely explains how to set up installer access in the configuration.


173-178: Correct addition of new sensor in settings table

The new "Battery Manual Charge" entry is properly formatted in the settings sensors table.

@edenhaus edenhaus changed the title Add Documentation for Manual Charge Switch #HSFDPMUW Add Documentation for Manual Charge Switch for Kostal Plenticore Jun 16, 2025
@home-assistant home-assistant bot added the parent-merged The parent PR has been merged already label Jun 26, 2025
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Schlauer-Hax 👍

@c0ffeeca7 c0ffeeca7 enabled auto-merge (squash) June 27, 2025 05:28
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_integrations/kostal_plenticore.markdown (1)

197-202: Tighten wording & remove redundancy in installer-access caution sentence

Line 200 repeats “using installer access” and misses a comma, which the linter flagged. A crisper version keeps the warning while avoiding duplication:

-The Battery Manual Charge sensor allows you to force charge the battery to 100%, regardless of PV generation or home usage.
-This setting is available when using installer access and should therefore only be used with the same caution as using installer access.
-More on [Installer Access](#installer-access)
+The Battery Manual Charge sensor allows you to force-charge the battery to 100 %, regardless of PV generation or home usage.  
+This setting is available when installer access is enabled, and should therefore be used with the same caution.  
+More on [Installer Access](#installer-access)
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 832b420 and 5d411b8.

📒 Files selected for processing (1)
  • source/_integrations/kostal_plenticore.markdown (3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`source/_integrations/*`: Integration documentation must use the provided template structure and section order.

source/_integrations/*: Integration documentation must use the provided template structure and section order.

📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)

List of files the instruction was applied to:

  • source/_integrations/kostal_plenticore.markdown
🪛 LanguageTool
source/_integrations/kostal_plenticore.markdown

[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...

(MISSING_IT_THERE)


[uncategorized] ~200-~200: Possible missing comma found.
Context: ...tting is available when using installer access and should therefore only be used with ...

(AI_HYDRA_LEO_MISSING_COMMA)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/kostal_plenticore.markdown (2)

33-36: Consider collapsing overlapping bullet points

Bullets 1 and 4 both tell the reader to proceed only if fully aware/with caution.
Merging them avoids repetition and shortens the list without losing information.

[ suggest_nitpick ]


173-178: Sensor table addition looks consistent with template

Header alignment, column order, and “RW” flag all match the style used above. No issues spotted.

@frenck frenck disabled auto-merge June 27, 2025 18:03
@frenck frenck merged commit 303d0b4 into home-assistant:next Jun 27, 2025
7 checks passed
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Jun 27, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants