-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
updated docs for Telegram bot #39528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe Telegram bot integration documentation was updated to include more detailed configuration instructions. Additions cover file access permissions, HTTPS certificate requirements, expanded reverse proxy examples, clarification of trusted network defaults, and the inclusion of Changes
Sequence Diagram(s)No sequence diagram generated as the changes are documentation-only and do not affect control flow or functionality. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/telegram_bot.markdown (1)
56-59
: Consider using a stronger admonition for certificate requirements
Recommending{% warning %}
instead of{% note %}
to emphasize that self-signed certificates are not supported and public CAs are required.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/telegram_bot.markdown
(4 hunks)
🔇 Additional comments (4)
source/_integrations/telegram_bot.markdown (4)
42-52
: New section for file access permissions looks good
Clarifies the need to add local directories toallowlist_external_dirs
for sending files. The example snippet is clear and correctly formatted.
75-83
: Expanded reverse proxy HTTP integration example is clear
The addeduse_x_forwarded_for
andtrusted_proxies
settings with a sample IP range accurately illustrate the required configuration.
113-115
: Trusted networks default values updated correctly
Specifying149.154.160.0/20, 91.108.4.0/22
as the default ACL aligns with Telegram’s official IP ranges.
122-124
:plain_text
parse mode inclusion is accurate
Addingplain_text
alongsidemarkdown
,markdownv2
, andhtml
matches the Telegram Bot API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @hanwg 👍
Thank you for contributing, @hanwg 💪 For future PRs, please fill out the PR template and provide the link to the parent PR. |
Proposed change
Improve documentation for new features:
allowlist_external_dirs
requirement for local filesplain_text
missing from the parse mode optionsType of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
plain_text
as a valid parse mode option.