-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Update supported hubs in fibaro integration #39516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
📝 WalkthroughWalkthroughThe documentation for the Fibaro integration was updated to include additional supported hubs, specifically the Nice Yubii Home, Zooz Z-Box Hub, and Yubii Home Pro. The text was revised to use more generic terminology and clarify compatibility with these hubs. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation
User ->> Documentation: Reads Fibaro integration page
Documentation -->> User: Shows updated list of supported hubs (Fibaro Home Center, Nice Yubii Home, Zooz Z-Box Hub, Yubii Home Pro)
User ->> Documentation: Looks for connection instructions
Documentation -->> User: Provides generic instructions for connecting supported hubs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/fibaro.markdown (3)
35-35
: Use consistent list formatting and Oxford commas in the intro
The sentence should list the hubs in parallel with commas (including the Oxford comma) and remove extra articles for clarity.
Apply:-The Fibaro integration allows you to connect Home Assistant to a Fibaro Home Center, a Nice Yubii Home or a ZooZ Z-Box Hub so that you can control and monitor the connected devices and run scenes. Home Assistant uses a local connection to connect to the hub. +The Fibaro integration allows you to connect Home Assistant to Fibaro Home Center, Nice Yubii Home, or ZooZ Z-Box Hub, enabling control and monitoring of connected devices and scene execution. Home Assistant uses a local connection to the hub.
39-39
: Improve list clarity in supported hub models
The comma placement around "Nice Yubii Home" and "Yubii Home Pro" is inconsistent. Consider:-Fibaro Home Center 2, Home Center Lite, Home Center 3, Home Center 3 Lite, and Nice Yubii Home, Yubii Home Pro. +Fibaro Home Center 2, Home Center Lite, Home Center 3, Home Center 3 Lite, Nice Yubii Home, and Yubii Home Pro.
41-41
: Correct brand casing for ZooZ
The hub name should match the official “ZooZ” styling:-This integration also allows you to connect your Zooz Z-Box Hub to Home Assistant. +This integration also allows you to connect your ZooZ Z-Box Hub to Home Assistant.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/fibaro.markdown
(1 hunks)
Even if linked to a code change the documentation is already relevant for the current branch so that should be ok in my opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is not correct when looking at the linked Core pull request.
Virtual integrations must have their own integration page.
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
Update list of supported hubs.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit