Skip to content

Update supported hubs in fibaro integration #39516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: current
Choose a base branch
from

Conversation

rappenze
Copy link
Contributor

@rappenze rappenze commented Jun 12, 2025

Proposed change

Update list of supported hubs.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated the Fibaro integration documentation to include support for Nice Yubii Home, Yubii Home Pro, and Zooz Z-Box Hub.
    • Clarified that the integration can connect the Zooz Z-Box Hub to Home Assistant.
    • Improved wording for broader hub compatibility.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Jun 12, 2025
Copy link

netlify bot commented Jun 12, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 2f26e07
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/684b3aa0742ed3000920faea
😎 Deploy Preview https://deploy-preview-39516--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@home-assistant home-assistant bot added the has-parent This PR has a parent PR in a other repo label Jun 12, 2025
@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jun 12, 2025
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@rappenze rappenze marked this pull request as ready for review June 12, 2025 20:23
Copy link
Contributor

coderabbitai bot commented Jun 12, 2025

📝 Walkthrough

Walkthrough

The documentation for the Fibaro integration was updated to include additional supported hubs, specifically the Nice Yubii Home, Zooz Z-Box Hub, and Yubii Home Pro. The text was revised to use more generic terminology and clarify compatibility with these hubs.

Changes

File Change Summary
source/_integrations/fibaro.markdown Expanded list of supported hubs and updated descriptions to clarify compatibility and terminology.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Documentation
    User ->> Documentation: Reads Fibaro integration page
    Documentation -->> User: Shows updated list of supported hubs (Fibaro Home Center, Nice Yubii Home, Zooz Z-Box Hub, Yubii Home Pro)
    User ->> Documentation: Looks for connection instructions
    Documentation -->> User: Provides generic instructions for connecting supported hubs
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between abe87b7 and 2f26e07.

📒 Files selected for processing (1)
  • source/_integrations/fibaro.markdown (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • source/_integrations/fibaro.markdown
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
source/_integrations/fibaro.markdown (3)

35-35: Use consistent list formatting and Oxford commas in the intro
The sentence should list the hubs in parallel with commas (including the Oxford comma) and remove extra articles for clarity.
Apply:

-The Fibaro integration allows you to connect Home Assistant to a Fibaro Home Center, a Nice Yubii Home or a ZooZ Z-Box Hub so that you can control and monitor the connected devices and run scenes. Home Assistant uses a local connection to connect to the hub.
+The Fibaro integration allows you to connect Home Assistant to Fibaro Home Center, Nice Yubii Home, or ZooZ Z-Box Hub, enabling control and monitoring of connected devices and scene execution. Home Assistant uses a local connection to the hub.

39-39: Improve list clarity in supported hub models
The comma placement around "Nice Yubii Home" and "Yubii Home Pro" is inconsistent. Consider:

-Fibaro Home Center 2, Home Center Lite, Home Center 3, Home Center 3 Lite, and Nice Yubii Home, Yubii Home Pro.
+Fibaro Home Center 2, Home Center Lite, Home Center 3, Home Center 3 Lite, Nice Yubii Home, and Yubii Home Pro.

41-41: Correct brand casing for ZooZ
The hub name should match the official “ZooZ” styling:

-This integration also allows you to connect your Zooz Z-Box Hub to Home Assistant.
+This integration also allows you to connect your ZooZ Z-Box Hub to Home Assistant.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 06bb376 and abe87b7.

📒 Files selected for processing (1)
  • source/_integrations/fibaro.markdown (1 hunks)

@rappenze
Copy link
Contributor Author

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Even if linked to a code change the documentation is already relevant for the current branch so that should be ok in my opinion.

@rappenze rappenze removed their assignment Jun 12, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is not correct when looking at the linked Core pull request.

Virtual integrations must have their own integration page.

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 27, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants