Skip to content

Fix plurality of virtual integrations #38322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

Fix plurality of virtual integrations #38322

merged 1 commit into from
Apr 2, 2025

Conversation

pwbriggs
Copy link
Contributor

@pwbriggs pwbriggs commented Apr 2, 2025 •
edited by coderabbitai bot
Loading

Proposed change

Fix the plurality of the introduction paragraph before the list of new virtual integrations added in 2025.4.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features
    • Updated the Home Assistant 2025.4 release notes to reflect that multiple virtual integrations are now available.
    • The release information now highlights three new integrations—FrankEver, LinkedGo, and Ogemray—providing enhanced connectivity options.
    • This revision offers a clearer, more user-friendly description of the new offerings.

@pwbriggs
Fix plurality of virtual integrations
88d9a6c 
Fix the plurality of the introduction paragraph before the list of new virtual integrations added in 2025.4.
@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch rc This PR is against the RC branch labels Apr 2, 2025
@home-assistant
Copy link

home-assistant bot commented Apr 2, 2025

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@netlify Netlify
Copy link

netlify bot commented Apr 2, 2025 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 88d9a6c
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/67ec7f3e99bf61000857253f
😎 Deploy Preview https://deploy-preview-38322--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 2, 2025

📝 Walkthrough

Walkthrough

The pull request updates the release notes for Home Assistant 2025.4 by revising a phrase to correctly reference multiple new virtual integrations. Specifically, the text "This one is new:" has been changed to "These ones are new:" and now introduces three integrations: FrankEver, LinkedGo, and Ogemray, which are provided by Shelly and added by @bieniu. No other parts of the release notes or exported entities were altered.

Changes

File Change Summary
source/_posts/2025-04-02-release-20254.markdown Changed wording from "This one is new:" to "These ones are new:" to reflect that multiple new integrations (FrankEver, LinkedGo, Ogemray) are being introduced.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_posts/2025-04-02-release-20254.markdown (1)

316-319: Enhanced Plurality for Virtual Integrations

The updated wording now correctly reflects that multiple virtual integrations are being introduced. Changing the phrase to “These ones are new:” aligns well with the plural list that follows, improving the clarity of the documentation.

Nitpick: For a slightly more formal tone consistent with the rest of the release notes, consider revising “These ones are new:” to “These are new:” as suggested by LanguageTool.

🧰 Tools
🪛 LanguageTool

[grammar] ~318-~318: In formal contexts, “These” is sufficient.
Context: ... integrations to help with findability. These ones are new: - [FrankEver], provided b...

(THESE_ONES)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5baece and 88d9a6c.

📒 Files selected for processing (1)
  • source/_posts/2025-04-02-release-20254.markdown (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_posts/2025-04-02-release-20254.markdown

[grammar] ~318-~318: In formal contexts, “These” is sufficient.
Context: ... integrations to help with findability. These ones are new: - [FrankEver], provided b...

(THESE_ONES)

frenck
frenck approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pwbriggs 👍

../Frenck

@github-project-automation github-project-automation bot moved this from Todo to Approved in Documentation PRs Apr 2, 2025
@frenck frenck merged commit 718e73f into home-assistant:rc Apr 2, 2025
7 checks passed
@home-assistant home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Apr 2, 2025
@github-project-automation github-project-automation bot moved this from Approved to Done in Documentation PRs Apr 2, 2025
@frenck frenck mentioned this pull request Apr 2, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@frenck frenck frenck approved these changes

Assignees

@pwbriggs pwbriggs

Labels
rc This PR is against the RC branch
Projects
No open projects
Documentation PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwbriggs @frenck