Skip to content

Fix spelling of Bosch in 2025-04-02 rc notes #38290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

Hedda
Copy link
Contributor

@Hedda Hedda commented Mar 31, 2025

Proposed change

Correct spelling for new bosch_alarm integration and link to @sanjay900

For reference, it is for Bosch alarm panels from Bosch Intrusion Alarm Systems (i.e. intruder/burglar alarm) solutions from Bosch Security and Safety Systems:

Type of change

  • Spelling, grammar or other readability improvements (rc branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated the release notes for the Bosch Alarm integration to improve clarity.
    • Corrected the spelling from "Bosh" to "Bosch" and refined the description to better explain its functionality in controlling and monitoring Bosch intrusion alarm systems/control panels.

Correct spelling for new bosch_alarm integration and link to @sanjay900

* home-assistant/core#138497
* home-assistant/core#138497
* home-assistant/brands#6557

For reference, it is for Bosch alarm panels from Bosch Intrusion Alarm Systems (i.e. intruder/burglar alarm) solutions from Bosch Security and Safety Systems:

* https://www.boschsecurity.com/us/en/solutions/intrusion-alarm-systems/
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch rc This PR is against the RC branch labels Mar 31, 2025
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 99e7d38
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/67ea46183be638000897df39
😎 Deploy Preview https://deploy-preview-38290--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Mar 31, 2025

📝 Walkthrough

Walkthrough

The pull request updates the release notes documentation for the Home Assistant integration. It corrects the integration name from "Bosh Alarm" to "Bosch Alarm", refines the description to detail the functionality as controlling intrusion alarm systems/control panels, and updates the contributor attribution from [@?] to [@sanjay900].

Changes

File Change Summary
source/_posts/2025-04-02-release-20254.markdown Corrected integration name to "Bosch Alarm", revised the description to "Control and monitor your Bosch intrusion alarm systems / control panels", and updated the contributor to [@sanjay900].

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (1)
source/_posts/2025-04-02-release-20254.markdown (1)

314-314: 🛠️ Refactor suggestion

Ensure consistency in link reference naming.
The link reference defined as “[Bosh Alarm]: /integrations/bosh_alarm” still contains the misspelling “Bosh”. For consistency with the updated integration name “Bosch Alarm”, consider updating both the display text and the reference identifier (and URL if applicable) to reflect the correct spelling.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

314-314: Link and image reference definitions should be needed
Unused link or image reference definition: "bosh alarm"

(MD053, link-image-reference-definitions)

🧹 Nitpick comments (1)
source/_posts/2025-04-02-release-20254.markdown (1)

309-310: Update “Bosch Alarm” integration entry with corrected spelling and detailed description.
The integration entry now correctly spells “Bosch Alarm” and provides a clearer description of its functionality along with the updated contributor attribution ([@sanjay900]). Please verify that this updated text fits the documentation style and messaging.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da02fe7 and 99e7d38.

📒 Files selected for processing (1)
  • source/_posts/2025-04-02-release-20254.markdown (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Hedda 👍

../Frenck

@github-project-automation github-project-automation bot moved this from Todo to Approved in Documentation PRs Mar 31, 2025
@frenck frenck merged commit 59efa79 into home-assistant:rc Mar 31, 2025
7 checks passed
@home-assistant home-assistant bot removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Mar 31, 2025
@github-project-automation github-project-automation bot moved this from Approved to Done in Documentation PRs Mar 31, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo rc This PR is against the RC branch
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants