Skip to content

Add Clock Card documentation #38242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2025
Merged

Conversation

mrdarrengriffin
Copy link
Contributor

@mrdarrengriffin mrdarrengriffin commented Mar 27, 2025

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features
    • Introduced a Clock card for dashboards that displays the current time in various formats.
    • Added configurable options such as clock size, seconds display, and time format.
    • Provided visual guides demonstrating the card’s appearance in different configurations to support seamless integration on multiple devices.
    • Added detailed documentation for the Clock card's functionality and usage examples.

@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Mar 27, 2025
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

Copy link

netlify bot commented Mar 27, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit c71a90f
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/67e63855ffa98c00084c6ec3
😎 Deploy Preview https://deploy-preview-38242--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@frenck frenck added this to the 2025.4 milestone Mar 27, 2025
@mrdarrengriffin mrdarrengriffin changed the title Add Clock Card docuumentation Add Clock Card documentation Mar 27, 2025
@frenck frenck added the parent-merged The parent PR has been merged already label Mar 27, 2025
@frenck frenck requested a review from Copilot March 27, 2025 22:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for the Clock card integration by introducing a new markdown file.

  • Adds a new documentation file for the Clock card including images and configuration examples.
  • Provides detailed configuration options and usage examples for different dashboard sizes.

@mrdarrengriffin mrdarrengriffin marked this pull request as ready for review March 27, 2025 23:33
Copy link
Contributor

coderabbitai bot commented Mar 27, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

A new markdown file has been added to the documentation that describes the Clock card feature. The file provides metadata such as card type, title, and description while outlining configuration options for the Clock card. It details settings for aspects like clock size, seconds display, and time format. The document also includes YAML examples to demonstrate usage on various devices and images that show the Clock card in different configurations (default, large, and medium).

Changes

File Change Summary
source/_dashboards/clock.markdown New markdown file that documents the Clock card feature with metadata, configurable settings (clock size, display seconds, time format), YAML examples, and illustrative images.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Dashboard
    participant ClockCard
    User->>Dashboard: Open dashboard view
    Dashboard->>ClockCard: Load Clock card configuration
    ClockCard-->>Dashboard: Provide configuration details and time data
    Dashboard->>User: Render Clock card with current time and settings
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 399b44c and c71a90f.

📒 Files selected for processing (1)
  • source/_dashboards/clock.markdown (1 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (6)
source/_dashboards/clock.markdown (6)

1-9: Improve YAML header description clarity.
The metadata is well structured. Consider simplifying the phrase “a variety of formats and sizes” to “multiple formats and sizes” to enhance clarity and conciseness.


11-11: Rephrase introductory text for clarity.
The sentence “The Clock card shows the current time in a variety of formats and sizes.” can be reworded to “The Clock card shows the current time in multiple formats and sizes.” for brevity and clarity.

🧰 Tools
🪛 LanguageTool

[style] ~11-~11: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
Context: ...he Clock card shows the current time in a variety of formats and sizes.

<im...

(A_VARIETY_OF)


26-27: Punctuation improvement for Clock Size description.
The description currently reads:
Adjusts the size of the text allowing a wider range of use with different types of dashboards. Defaults to small
Consider inserting a comma after “text” to improve readability, e.g.:
Adjusts the size of the text, allowing a wider range of use with different types of dashboards. Defaults to small

🧰 Tools
🪛 LanguageTool

[uncategorized] ~27-~27: Possible missing comma found.
Context: ... description: Adjusts the size of the text allowing a wider range of use with diff...

(AI_HYDRA_LEO_MISSING_COMMA)


28-29: Enhance punctuation and hyphenation in Display Seconds description.
The current text:
Shows seconds alongside the clock providing the time format is in a 12 hour format
Could be revised to:
Shows seconds alongside the clock, provided the time format is in a 12-hour format
This adds clarity and correctly hyphenates “12-hour”.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~29-~29: Possible missing comma found.
Context: ...escription: Shows seconds alongside the clock providing the time format is in a 12 ho...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~29-~29: When a number forms part of an adjectival compound, use a hyphen.
Context: ...clock providing the time format is in a 12 hour format Time Format: description: Allo...

(MISSING_HYPHEN)


20-23: Remove extra blank lines for markdown consistency.
There are consecutive blank lines between sections (e.g., around line 22). Please reduce these to a single blank line to comply with markdownlint rules.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

22-22: Multiple consecutive blank lines
Expected: 1; Actual: 2

(MD012, no-multiple-blanks)


78-78: Add a trailing newline for compliance.
Ensure that the file ends with a single newline character to conform with markdown style guidelines.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

78-78: Files should end with a single newline character
null

(MD047, single-trailing-newline)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3701b32 and 399b44c.

⛔ Files ignored due to path filters (3)
  • source/images/dashboards/clock_card_default.png is excluded by !**/*.png
  • source/images/dashboards/clock_card_large.png is excluded by !**/*.png
  • source/images/dashboards/clock_card_medium.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • source/_dashboards/clock.markdown (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_dashboards/clock.markdown

[style] ~11-~11: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
Context: ...he Clock card shows the current time in a variety of formats and sizes.

<im...

(A_VARIETY_OF)


[uncategorized] ~27-~27: Possible missing comma found.
Context: ... description: Adjusts the size of the text allowing a wider range of use with diff...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~29-~29: Possible missing comma found.
Context: ...escription: Shows seconds alongside the clock providing the time format is in a 12 ho...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~29-~29: When a number forms part of an adjectival compound, use a hyphen.
Context: ...clock providing the time format is in a 12 hour format Time Format: description: Allo...

(MISSING_HYPHEN)

🪛 markdownlint-cli2 (0.17.2)
source/_dashboards/clock.markdown

22-22: Multiple consecutive blank lines
Expected: 1; Actual: 2

(MD012, no-multiple-blanks)


78-78: Files should end with a single newline character
null

(MD047, single-trailing-newline)

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Mar 28, 2025
@c0ffeeca7
Copy link
Contributor

for future PR, please fill out the PR template and add the related parent PR.

Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Thank you, @mrdarrengriffin 👍

@github-project-automation github-project-automation bot moved this from Todo to Approved in Documentation PRs Mar 28, 2025
@c0ffeeca7 c0ffeeca7 merged commit 822c081 into home-assistant:next Mar 28, 2025
5 of 7 checks passed
@home-assistant home-assistant bot removed parent-merged The parent PR has been merged already in-progress This PR/Issue is currently being worked on labels Mar 28, 2025
@github-project-automation github-project-automation bot moved this from Approved to Done in Documentation PRs Mar 28, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2025
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Apr 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants