Improve instructions for a custom app registration to onedrive #37372
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Warning Rate limit exceeded@zweckj has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 4 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe documentation for the Microsoft OneDrive integration has been updated to include additional configuration details. The new instructions specify that app registration settings must use “Personal Microsoft accounts only” for Supported account types and include the proper Redirect URI. An illustrative image has been added to help users configure a custom app registration correctly. No modifications were made to any exported or public entities. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/onedrive.markdown (1)
56-62: Enhance clarity for custom app registration settingsThe added instructions clearly state which app registration settings need to be configured, including the "Supported account types" as Personal Microsoft accounts only and the "Redirect URI" set to a specific Home Assistant endpoint. The inclusion of an illustrative image further supports clarity for users.
One suggestion: If applicable, consider adding a brief note that reminds users to verify that their deployment endpoint (i.e. the Redirect URI) matches the one provided here ("https://my.home-assistant.io/redirect/oauth") or update accordingly if their environment differs.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
source/images/integrations/onedrive/onedrive-app-registration.pngis excluded by!**/*.png
📒 Files selected for processing (1)
source/_integrations/onedrive.markdown(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/onedrive.markdown (1)
65-68: Optimize Markdown Formatting.
Static analysis has flagged multiple consecutive blank lines (notably at lines 65 and 68). Please remove the redundant blank lines to adhere to MD012 guidelines for maintaining consistent formatting.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
65-65: Multiple consecutive blank lines
Expected: 1; Actual: 2(MD012, no-multiple-blanks)
68-68: Multiple consecutive blank lines
Expected: 1; Actual: 2(MD012, no-multiple-blanks)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/onedrive.markdown(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/onedrive.markdown
65-65: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
68-68: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/onedrive.markdown (2)
56-60: Enhanced Custom App Registration Instructions.
The newly added section clearly outlines the necessary settings—specifically "Supported account types" set to Personal Microsoft accounts only and the required "Redirect URI"—which improves the clarity and precision of the app registration instructions for custom credentials.
69-71: Clear Note on Credential Implications.
The note regarding the change of backup folders when switching from default to custom credentials is informative and well-placed. It effectively alerts the user to potential disruptions in backup management.
|
|
||
| ## Troubleshooting | ||
|
|
||
| {% details "Unknown error while adding the integration" %} |
There was a problem hiding this comment.
It would be better, if this could be improved at integration level by giving a better error.
There was a problem hiding this comment.
I know, but I don't know how to detect that yet hence the "unknown" error
Proposed change
SSIA
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.Summary by CodeRabbit