-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Update manual setup to reflect current Google Developer Console #37085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe changes to the Google Assistant integration documentation focus on improving the setup instructions' clarity and organization. The documentation has been restructured to provide a more logical and detailed guide for users, with enhanced explanations of prerequisites, project creation in the Google Developer Console, account linking, and service account setup. The modifications aim to make the setup process more comprehensible by introducing clearer headings, rephrasing steps, and adding more specific guidance. Changes
Sequence DiagramsequenceDiagram
participant User
participant "Google Developer Console"
participant "Actions on Google"
participant "Home Assistant"
User->>+Google Developer Console: Create new project
Google Developer Console-->>User: Project created
User->>Google Developer Console: Configure OAuth Client ID
User->>Google Developer Console: Set up Cloud-to-Cloud integration
User->>Actions on Google: Configure account linking
User->>Home Assistant: Set up service account
Home Assistant->>Actions on Google: Sync devices
The sequence diagram illustrates the high-level flow of setting up the Google Assistant integration, showing the key interactions between the user, Google Developer Console, Actions on Google, and Home Assistant during the configuration process. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/google_assistant.markdown (3)
37-37
: Improve clarity of DNS propagation warning.The sentence structure could be improved for better readability.
-If you make DNS changes to accomplish this, ensure you have allowed up to the full 48 hours for DNS changes to propagate, otherwise, Google may not be able to reach your server. +If you make DNS changes to accomplish this, ensure you have allowed up to the full 48 hours for DNS changes to propagate. If DNS changes haven't fully propagated, Google may not be able to reach your server.🧰 Tools
🪛 LanguageTool
[typographical] ~37-~37: The word “otherwise” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ...to the full 48 hours for DNS changes to propagate, otherwise, Google may not be able to reach your se...(THUS_SENTENCE)
51-52
: Add clarification for OAuth Client ID format.The OAuth Client ID step is crucial and could benefit from additional context.
- 8. Under **Account Linking**, in the **OAuth Client ID** field, enter `https://oauth-redirect.googleusercontent.com/r/[YOUR_PROJECT_ID]`. - 9. Replace `[YOUR_PROJECT_ID]` with your project ID from above. + 8. Under **Account Linking**, in the **OAuth Client ID** field, enter the following URL, replacing `[YOUR_PROJECT_ID]` with your project ID from step 3: + ``` + https://oauth-redirect.googleusercontent.com/r/[YOUR_PROJECT_ID] + ``` + For example, if your project ID is "my-project-12345", the URL would be: + ``` + https://oauth-redirect.googleusercontent.com/r/my-project-12345 + ```
65-68
: Maintain consistent hyphenation in UI navigation terms.For consistency and proper grammar, "left hand" should be hyphenated when used as a compound modifier.
-2. In the left hand menu of your project, select the **Analytics** link. +2. In the left-hand menu of your project, select the **Analytics** link. - 1. In the left hand menu, select **Credentials**. + 1. In the left-hand menu, select **Credentials**.🧰 Tools
🪛 LanguageTool
[uncategorized] ~65-~65: Did you mean the adjective “left-hand”?
Context: ... - You do not need to test. 2. In the left hand menu of your project, select the **Anal...(MISSING_HYPHEN)
[uncategorized] ~68-~68: Did you mean the adjective “left-hand”?
Context: ...n](#enable-device-sync)). 1. In the left hand menu, select Credentials. 2. In...(MISSING_HYPHEN)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/google_assistant.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/google_assistant.markdown
[typographical] ~37-~37: The word “otherwise” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ...to the full 48 hours for DNS changes to propagate, otherwise, Google may not be able to reach your se...
(THUS_SENTENCE)
[uncategorized] ~48-~48: Consider adding a hyphen.
Context: ...d-to-Cloud integration**. 5. In the bottom right corner, select Next: Develop, then ...
(TOP_LEFT_CORNER)
[uncategorized] ~65-~65: Did you mean the adjective “left-hand”?
Context: ... - You do not need to test. 2. In the left hand menu of your project, select the **Anal...
(MISSING_HYPHEN)
[uncategorized] ~68-~68: Did you mean the adjective “left-hand”?
Context: ...n](#enable-device-sync)). 1. In the left hand menu, select Credentials. 2. In...
(MISSING_HYPHEN)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/google_assistant.markdown (1)
86-87
: LGTM!The final configuration steps are clear and well-referenced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @c0ffeeca7 👍
../Frenck
Proposed change
Update manual setup to reflect current Google Developer Console
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit