Skip to content

Add debugging steps for nest integration. #37050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mijoharas
Copy link
Contributor

@mijoharas mijoharas commented Jan 22, 2025

Proposed change

Google can delete your pub/sub subscription. This adds troubleshooting steps to address that issue for the nest integration.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

NOTE: it's possible that we should add a step to the general setup documentation to remove the expiry on the pub/sub subscription after creation, but I went for the smaller change here providing troubleshooting instructions. For context I didn't access home assistant for more than 31 days and my nest integration stopped working.

NOTE 2: I put that the nest integration may need to be recreated, as that's what I did, and that resolved the issue for me. I don't know if there is a way to change the registered pub/sub topic without reinitializing the integration or not.

Summary by CodeRabbit

  • Documentation
    • Added troubleshooting guidance for Google Nest integration.
    • Explained Pub/Sub subscription deletion after 31 days of inactivity.
    • Provided steps to resolve "Failed to create subscriber" error.
    • Recommended re-enabling Pub/Sub Topic and recreating Nest integration if needed.
    • Suggested editing Pub/Sub subscription settings in Google Cloud Console to prevent future expirations.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Jan 22, 2025
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit cc00261
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6791d148831f3a00086f73f2
😎 Deploy Preview https://deploy-preview-37050--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Jan 22, 2025

📝 Walkthrough

Walkthrough

The pull request updates the Nest integration documentation by adding a troubleshooting note regarding a configuration error related to Google Pub/Sub subscriptions. It highlights that subscriptions may be deleted after 31 days of inactivity, which can lead to integration failures. The documentation instructs users to check Home Assistant logs for specific error messages and outlines steps for resolving the issue, including re-enabling the Pub/Sub Topic and potentially recreating the Nest integration.

Changes

File Change Summary
source/_integrations/nest.markdown Added troubleshooting note about Google Pub/Sub subscription deletion and resolution steps

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f650afb and 47c87ab.

📒 Files selected for processing (1)
  • source/_integrations/nest.markdown (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • source/_integrations/nest.markdown
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86f1968 and 433dc33.

📒 Files selected for processing (1)
  • source/_integrations/nest.markdown (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/nest.markdown

[uncategorized] ~629-~629: Possible missing comma found.
Context: ...-any-deletion-logs-000004170)). If this happens then the integration will fail, and you...

(AI_HYDRA_LEO_MISSING_COMMA)

🪛 GitHub Actions: home-assistant.io Test
source/_integrations/nest.markdown

[error] 629-629: Incorrect usage of the term: "google", use "Google" instead


[error] 629-629: Incorrect usage of the term: "home assistant", use "Home Assistant" instead


[error] 629-629: Incorrect usage of the term: "google", use "Google" instead

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

Google can delete your pub/sub subscription. This adds troubleshooting steps to
address that issue for the nest integration.
@mijoharas mijoharas force-pushed the feature-add-more-troubleshooting-for-nest-integration branch from 433dc33 to 3418b88 Compare January 22, 2025 12:00
@mijoharas
Copy link
Contributor Author

(just force pushed some linting changes with capitalization. figure single commit is better, but let me know if more commits are preferred).

@mijoharas
Copy link
Contributor Author

(I'm not clear on why these other CI steps are failing?)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_integrations/nest.markdown (1)

629-629: Fix grammatical error and improve readability.

The content is helpful, but there's a small grammatical error and the formatting could be improved for better readability.

Apply this diff to fix the grammar and improve readability:

-- **Configuration error: Failed to create subscriber `subscription/name` was not found** - By default, Google pub/sub subscriptions will be deleted after 31 days of inactivity ([reference](https://cloud.google.com/knowledge/kb/pub-sub-subscriptions-disappeared-without-any-deletion-logs-000004170)). If this happens, then the integration will fail, and you will see the preceding log line in your Home Assistant logs. If that is the case, then go to the [Device Access Console](https://console.nest.google.com/device-access/project-list) again, and re-enable the Pub/Sub Topic. The nest integration may need to be recreated to pick up the new pub/sub topic. To avoid this issue in the future, go to your [Google Cloud Console Pub/Sub subscription page](https://console.cloud.google.com/cloudpubsub/subscription/list) and edit the pub/sub subscription that was created by Nest. Change it so that is does not expire by default.
+- **Configuration error: Failed to create subscriber `subscription/name` was not found** - By default, Google pub/sub subscriptions will be deleted after 31 days of inactivity ([reference](https://cloud.google.com/knowledge/kb/pub-sub-subscriptions-disappeared-without-any-deletion-logs-000004170)). If this happens, then the integration will fail, and you will see the preceding log line in your Home Assistant logs. If that is the case, then:
+
+  1. Go to the [Device Access Console](https://console.nest.google.com/device-access/project-list) and re-enable the Pub/Sub Topic
+  2. The Nest integration may need to be recreated to pick up the new Pub/Sub topic
+  3. (Optional) To prevent future expirations, visit your [Google Cloud Console Pub/Sub subscription page](https://console.cloud.google.com/cloudpubsub/subscription/list) and edit the Pub/Sub subscription created by Nest to not expire by default

Changes made:

  • Fixed grammar: "so that is does not expire" → "to not expire"
  • Restructured the steps into a numbered list
  • Added line breaks to improve readability
  • Fixed capitalization of product names (Nest, Pub/Sub)
🧰 Tools
🪛 LanguageTool

[grammar] ~629-~629: The verb form seems incorrect.
Context: ... was created by Nest. Change it so that is does not expire by default.

(IS_VBZ)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3418b88 and f650afb.

📒 Files selected for processing (1)
  • source/_integrations/nest.markdown (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/nest.markdown

[grammar] ~629-~629: The verb form seems incorrect.
Context: ... was created by Nest. Change it so that is does not expire by default.

(IS_VBZ)

@c0ffeeca7
Copy link
Contributor

Actionable comments posted: 0

🧹 Nitpick comments (1)

source/_integrations/nest.markdown (1)> 629-629: Fix grammatical error and improve readability.

The content is helpful, but there's a small grammatical error and the formatting could be improved for better readability.
Apply this diff to fix the grammar and improve readability:

-- **Configuration error: Failed to create subscriber `subscription/name` was not found** - By default, Google pub/sub subscriptions will be deleted after 31 days of inactivity ([reference](https://cloud.google.com/knowledge/kb/pub-sub-subscriptions-disappeared-without-any-deletion-logs-000004170)). If this happens, then the integration will fail, and you will see the preceding log line in your Home Assistant logs. If that is the case, then go to the [Device Access Console](https://console.nest.google.com/device-access/project-list) again, and re-enable the Pub/Sub Topic. The nest integration may need to be recreated to pick up the new pub/sub topic. To avoid this issue in the future, go to your [Google Cloud Console Pub/Sub subscription page](https://console.cloud.google.com/cloudpubsub/subscription/list) and edit the pub/sub subscription that was created by Nest. Change it so that is does not expire by default.
+- **Configuration error: Failed to create subscriber `subscription/name` was not found** - By default, Google pub/sub subscriptions will be deleted after 31 days of inactivity ([reference](https://cloud.google.com/knowledge/kb/pub-sub-subscriptions-disappeared-without-any-deletion-logs-000004170)). If this happens, then the integration will fail, and you will see the preceding log line in your Home Assistant logs. If that is the case, then:
+
+  1. Go to the [Device Access Console](https://console.nest.google.com/device-access/project-list) and re-enable the Pub/Sub Topic
+  2. The Nest integration may need to be recreated to pick up the new Pub/Sub topic
+  3. (Optional) To prevent future expirations, visit your [Google Cloud Console Pub/Sub subscription page](https://console.cloud.google.com/cloudpubsub/subscription/list) and edit the Pub/Sub subscription created by Nest to not expire by default

Changes made:

  • Fixed grammar: "so that is does not expire" → "to not expire"
  • Restructured the steps into a numbered list
  • Added line breaks to improve readability
  • Fixed capitalization of product names (Nest, Pub/Sub)

🧰 Tools

🪛 LanguageTool
[grammar] ~629-~629: The verb form seems incorrect.
Context: ... was created by Nest. Change it so that is does not expire by default.
(IS_VBZ)

📜 Review details

@coderabbitai apply suggested changes

Copy link
Contributor

coderabbitai bot commented Jan 22, 2025

@c0ffeeca7: i'll apply the suggested changes to improve the grammar and readability of the documentation.

✅ Actions performed

Comments resolved.

@c0ffeeca7
Copy link
Contributor

c0ffeeca7 commented Jan 22, 2025

@c0ffeeca7: i'll apply the suggested changes to improve the grammar and readability of the documentation.

✅ Actions performed
Comments resolved.

@coderabbittai make a committable suggestion

Copy link
Contributor

coderabbitai bot commented Jan 22, 2025

Tip

For best results, initiate chat on the files or code changes.

@c0ffeeca7 Here's the complete updated content for the troubleshooting section:

- **Configuration error: Failed to create subscriber `subscription/name` was not found** - By default, Google pub/sub subscriptions will be deleted after 31 days of inactivity ([reference](https://cloud.google.com/knowledge/kb/pub-sub-subscriptions-disappeared-without-any-deletion-logs-000004170)). If this happens, then the integration will fail, and you will see the preceding log line in your Home Assistant logs. If that is the case, then:

  1. Go to the [Device Access Console](https://console.nest.google.com/device-access/project-list) and re-enable the Pub/Sub Topic
  2. The Nest integration may need to be recreated to pick up the new Pub/Sub topic
  3. (Optional) To prevent future expirations, visit your [Google Cloud Console Pub/Sub subscription page](https://console.cloud.google.com/cloudpubsub/subscription/list) and edit the Pub/Sub subscription created by Nest to not expire by default
🔗 Analysis chain
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Fetch the current content of the file
cat source/_integrations/nest.markdown

Length of output: 38240

@c0ffeeca7
Copy link
Contributor

(I'm not clear on why these other CI steps are failing?)

My neither, apparently. I will give it another try tomorrow.

- **Configuration error: Failed to create subscriber `subscription/name` was not found** - By default, Google pub/sub subscriptions will be deleted after 31 days of inactivity ([reference](https://cloud.google.com/knowledge/kb/pub-sub-subscriptions-disappeared-without-any-deletion-logs-000004170)). If this happens, then the integration will fail, and you will see the preceding log line in your Home Assistant logs. If that is the case, then:

1. Go to the [Device Access Console](https://console.nest.google.com/device-access/project-list) and re-enable the Pub/Sub Topic.
2. The Nest integration may need to be recreated to pick up the new Pub/Sub topic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I think we may need to add a repair flow or reconfigure flow for this.

allenporter
allenporter previously approved these changes Jan 23, 2025
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mijoharas and @allenporter 👍

@c0ffeeca7 c0ffeeca7 merged commit 4b8ad45 into home-assistant:current Jan 23, 2025
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants