aquacell.markdown: Expand documentation #37044
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request updates the AquaCell integration documentation to reflect changes in branding and supported devices. It clarifies that AquaCell is manufactured by Culligan and expands the support section to include compatibility with other Culligan brands, specifically mentioning TwinTec alongside Harvey, noting that TwinTec is made by Harvey. The reference to the 'myHarvey' mobile app has been standardized to lowercase, and the TwinTec Cobalt model has been added to the list of supported devices. Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/aquacell.markdown (1)
26-28: Add blank lines around the list for better readability.To improve markdown formatting and comply with markdown standards, add blank lines before and after the list.
These models are also recognizable by the required curved salt blocks. + - [AquaCell](https://www.aquacell-waterontharder.nl/aquacell) - [HarveyArc Water Softener](https://www.harveywatersofteners.co.uk/products/water-softeners/harveyarc-water-softener) - [TwinTec Cobalt](https://www.twintec.com/our-products/tt-cobalt/) +🧰 Tools
🪛 Markdownlint (0.37.0)
26-26: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/aquacell.markdown(1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
source/_integrations/aquacell.markdown
26-26: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
🔇 Additional comments (3)
source/_integrations/aquacell.markdown (3)
20-20: LGTM! Clear and informative addition.The addition of TwinTec support and its relationship to Harvey provides valuable context for users.
28-28: LGTM! Well-structured model addition.The TwinTec Cobalt model is added consistently with proper linking.
24-24: Verify app name formatting in app stores.Let's verify the correct capitalization of the app name in the official stores.
|
Arguably, they're all "Culligan" brands, not Aquacell variants.. https://culliganinternational.com/brands Probably should be mentioned... |
@Jordi1990 Should we actually rename the integration to match this? |
You're totally right, but I don't know how much of a hassle it is to change it. I would assume it would break existing configurations. |
|
I'd guess you may be able to rename it, then alias aquacell back to it.. Update the Harvey alias Not sure how HA would handle it, indeed |
Proposed change
** https://apps.apple.com/us/app/myharvey/id1551338436
** https://play.google.com/store/apps/details?id=com.harvey.sws
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.Summary by CodeRabbit