-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add Landis+Gyr E360 to known working meters #37043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Landis+Gyr E360 to known working meters #37043
Conversation
…ion regarding needing a special P1 cable
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request updates the documentation for the DSMR Smart Meter integration, focusing on improving clarity and expanding device support. The changes include correcting the spelling of "DSMR" from "DMSR", adding support for the Landis+Gyr E360 (DSMR 5) smart meter, and providing additional details about M-Bus support for DSMR version 5B. The documentation now clarifies the requirements for the E360 meter and its special P1 cable, while also highlighting the integration's ability to handle multiple gas and water meters. Changes
The changes are primarily documentation-related, improving the clarity and comprehensiveness of the DSMR Smart Meter integration documentation. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/dsmr.markdown (1)
68-69
: Consider adding more context about the special P1 cable requirement.While the remark about the E360's special cable requirement is valuable, it would be helpful to briefly explain why a special cable is needed (e.g., different voltage requirements, pin configuration, etc.). This would help users understand the importance of getting the correct cable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/dsmr.markdown
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/dsmr.markdown (2)
57-57
: LGTM! Spelling correction improves consistency.The correction from "DMSR" to "DSMR" aligns with the correct terminology used throughout the documentation.
58-58
: LGTM! New meter addition is well-documented.The addition of Landis+Gyr E360 with DSMR 5 support follows the existing format and includes a helpful reference to special requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @NanoBob 👍
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
If desired I can add the link to the webstore where I purchased my working cable, however I am uncertain what the stance is towards promoting specific stores / products so I didn't include the link for now.
Checklist
current
branch.next
branch.Summary by CodeRabbit