Support device removal in CoolMasterNet integration #147851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds support for removing devices that are no longer reported by the CoolMasterNet integration.
- Introduces
async_remove_config_entry_devicehook to automatically unregister disconnected units. - Adds a registry cleanup test to verify live devices cannot be removed and dead devices are pruned.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/components/coolmaster/test_init.py | Added test_registry_cleanup to validate removal behavior for live vs. dead devices. |
| homeassistant/components/coolmaster/init.py | Implemented async_remove_config_entry_device hook and imported DOMAIN and device_registry. |
Comments suppressed due to low confidence (1)
homeassistant/components/coolmaster/init.py:59
- Clarify that this hook returns True when a device should be removed (i.e., no longer present in
runtime_data.data) and False otherwise. For example:"""Return True if the device is no longer reported by the integration and can be removed."""
"""Remove a config entry from a device."""
frenck
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Allow device removal in CoolMasterNet.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: