Add reauth to Alexa Devices config flow #147773
Open
+160
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a reauthentication flow to the Alexa Devices integration, ensuring users can update credentials when sessions expire.
- Extracts a shared
validate_inputhelper and addsreauth_confirmsteps in the config flow - Raises
ConfigEntryAuthFailedin the coordinator for authentication errors - Adds strings, tests, and updates the quality scale for the new reauth flow
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/components/alexa_devices/test_config_flow.py | Added tests for successful and failed reauthentication |
| homeassistant/components/alexa_devices/config_flow.py | Implemented async_step_reauth and async_step_reauth_confirm, extracted validate_input |
| homeassistant/components/alexa_devices/strings.json | Added translation keys for the reauth confirm form and success abort |
| homeassistant/components/alexa_devices/coordinator.py | Switched to raising ConfigEntryAuthFailed on auth failure |
| homeassistant/components/alexa_devices/quality_scale.yaml | Marked reauthentication-flow as done |
Comments suppressed due to low confidence (3)
homeassistant/components/alexa_devices/quality_scale.yaml:38
- The
test-coveragerule is still marked astodoeven though tests for the new reauthentication flow have been added; please update this todoneor expand coverage for other missing behaviors.
test-coverage:
homeassistant/components/alexa_devices/config_flow.py:20
- The code references
vol.Schemabutvolis not imported; addimport voluptuous as volat the top of the file.
STEP_REAUTH_DATA_SCHEMA = vol.Schema(
homeassistant/components/alexa_devices/config_flow.py:112
- In the reauth flow, the updated password should come from
user_input[CONF_PASSWORD]instead ofentry_data, otherwise the config entry will retain the old password.
CONF_PASSWORD: entry_data[CONF_PASSWORD],
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add reauth to Alexa Devices config flow
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: