Improve validation for media selector #147768
Merged
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the media selector’s validation by making the entity_id field conditionally required based on whether an accept option is configured. It also updates the method’s return type annotation.
- Adjust return type hint from
dict[str, float]todict[str, str] - Introduce a mutable copy of the selector’s schema to add or remove the
entity_idrequirement - Call the original
DATA_SCHEMAfor validation
frenck
approved these changes
Jun 30, 2025
| # If accept is not set, the entity_id field is required | ||
| schema[vol.Required("entity_id")] = cv.entity_id_or_uuid | ||
|
|
||
| media: dict[str, str] = self.DATA_SCHEMA(data) |
There was a problem hiding this comment.
Where is the schema variable used?
There was a problem hiding this comment.
ah snap forgot to update that. let me fix.
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Improve the validation of the media selector.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: