Update pywmspro to 0.3.0 to wait for short-lived actions #147679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace action delays with detailed action responses.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the pywmspro dependency from 0.2.2 to 0.3.0 and adjusts the integration code to work with the new API. Key changes include:
- Updating the dependency version in both test and production requirements files.
- Modifying the manifest to reflect the updated pywmspro version.
- Removing action delay sleeps and adding a new parameter (responseType) to all API calls in light.py and cover.py.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| requirements_test_all.txt, requirements_all.txt | Updated dependency version for pywmspro |
| homeassistant/components/wmspro/manifest.json | Updated requirement version to match the new dependency |
| homeassistant/components/wmspro/light.py | Removed artificial delay and updated API action calls with detailed responseType parameter |
| homeassistant/components/wmspro/cover.py | Removed artificial delay and updated API action calls with detailed responseType parameter |
Comments suppressed due to low confidence (2)
homeassistant/components/wmspro/light.py:62
- The removal of the sleep delay and addition of the responseType parameter is correct; however, please add tests to ensure that the integration correctly handles the new detailed action responses without the delay.
)
homeassistant/components/wmspro/cover.py:60
- Since the sleep delay has been removed in favor of detailed response handling, please ensure that tests validate that the new behavior works as expected under various cover operations.
await action(percentage=100 - kwargs[ATTR_POSITION])
zweckj
requested changes
Jun 29, 2025
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
The bugfix requires the new dependency version for the new parameter responseType which is the only relevant change in the new version besides CI/CD stuff. |
zweckj
approved these changes
Jun 29, 2025
|
Thanks @zweckj |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Replace action delays with detailed action responses, revert #144836 to avoid unnecessary delay and lag.
I am not sure wether this should be considered a bugfix or not, but it should probably go into a beta phase.
Required dependency changes, everything except the final commit is just related to CI/CD:
mback2k/pywmspro@0.2.2...0.3.0
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: