Skip to content

Fix: Unhandled NoneType sessions in jellyfin #147659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2025
Merged

Fix: Unhandled NoneType sessions in jellyfin #147659

merged 2 commits into from
Jun 27, 2025

Conversation

zweckj
Copy link
Member

@zweckj zweckj commented Jun 27, 2025

Breaking change

Proposed change

Type of change

sessions could be None which broke the code

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Copilot Copilot AI review requested due to automatic review settings June 27, 2025 08:51
@zweckj zweckj requested a review from ctalkington as a code owner June 27, 2025 08:51
@home-assistant
Copy link

Hey there @RunC0deRun, @ctalkington, mind taking a look at this pull request as it has been labeled with an integration (jellyfin) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of jellyfin can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign jellyfin Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copilot
Copilot AI reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a guard in the Jellyfin coordinator to handle cases where sessions can be None, preventing attempts to iterate over a NoneType.

  • Introduce an early return when sessions is falsy.
  • Preserve the existing behavior of returning an empty mapping for no active sessions.
Comments suppressed due to low confidence (1)

homeassistant/components/jellyfin/coordinator.py:57

  • Add a pytest case simulating api_client.jellyfin.sessions returning None to verify that the coordinator method returns an empty dict without errors.
        if not sessions:

frenck
frenck approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @zweckj 👍

../Frenck

@frenck frenck added this to the 2025.7.0 milestone Jun 27, 2025
@zweckj zweckj merged commit 58c4348 into home-assistant:dev Jun 27, 2025
34 checks passed
@zweckj zweckj deleted the jellyfin/nontype-session branch June 27, 2025 09:00
frenck pushed a commit that referenced this pull request Jun 27, 2025
@zweckj @frenck
Fix: Unhandled NoneType sessions in jellyfin (#147659)
77ccfbd
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@frenck frenck frenck approved these changes

@joostlek joostlek joostlek approved these changes

@ctalkington ctalkington Awaiting requested review from ctalkington ctalkington is a code owner

Assignees

@ctalkington ctalkington

Labels
bugfix cherry-picked cla-signed integration: jellyfin Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.7.0
Development

Successfully merging this pull request may close these issues.

Jellyfin "TypeError: 'NoneType' object is not iterable"
4 participants
@zweckj @frenck @joostlek @ctalkington