Skip to content

Bump jellyfin-apiclient-python to 1.11.0 #147658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025

Conversation

zweckj
Copy link
Member

@zweckj zweckj commented Jun 27, 2025

Breaking change

Proposed change

jellyfin/jellyfin-apiclient-python@v1.10.0...v1.11.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Copilot Copilot AI review requested due to automatic review settings June 27, 2025 08:42
@zweckj zweckj requested a review from ctalkington as a code owner June 27, 2025 08:42
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict.

@home-assistant home-assistant bot added the small-pr PRs with less than 30 lines. label Jun 27, 2025
@home-assistant home-assistant bot marked this pull request as draft June 27, 2025 08:42
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @RunC0deRun, @ctalkington, mind taking a look at this pull request as it has been labeled with an integration (jellyfin) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of jellyfin can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign jellyfin Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request upgrades the jellyfin-apiclient-python dependency to version 1.11.0 in order to incorporate upstream fixes and adjustments. The key changes include:

  • Bumping the dependency version in both requirements files.
  • Updating the manifest.json to reflect the new dependency version.
  • Adjusting the connection state check in client_wrapper.py to use the updated enum-style conversion.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
requirements_test_all.txt Updated jellyfin-apiclient-python version from 1.10.0 to 1.11.0
requirements_all.txt Updated jellyfin-apiclient-python version from 1.10.0 to 1.11.0
homeassistant/components/jellyfin/manifest.json Updated dependency version in the requirements list
homeassistant/components/jellyfin/client_wrapper.py Changed connection state checking to use enum construction for updated API usage

@zweckj zweckj marked this pull request as ready for review June 27, 2025 08:43
@home-assistant home-assistant bot dismissed their stale review June 27, 2025 08:44

Stale

@frenck frenck added this to the 2025.7.0 milestone Jun 27, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @zweckj 👍

../Frenck

@zweckj zweckj merged commit 4a192a7 into home-assistant:dev Jun 27, 2025
44 checks passed
@zweckj zweckj deleted the jellyfin/1.11.0 branch June 27, 2025 09:07
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught exception KeyError: 'auth.server-id'
3 participants