Skip to content

Improve tests for binary sensor template #147657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 27, 2025
Merged

Improve tests for binary sensor template #147657

merged 9 commits into from
Jun 27, 2025

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Jun 27, 2025 •
edited
Loading

Proposed change

  • add tests for None template result
  • add tests for error template result
  • add type hints
  • use FrozenDateTimeFactory

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Petro31, @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (template) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of template can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign template Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@epenet epenet changed the title Add tests for binary sensor template Improve tests for binary sensor template Jun 27, 2025
@epenet epenet marked this pull request as ready for review June 27, 2025 10:41
@Copilot Copilot AI review requested due to automatic review settings June 27, 2025 10:41
@epenet epenet requested a review from a team as a code owner June 27, 2025 10:41
Copilot
Copilot AI reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the tests for the binary sensor template by adding new test cases for None and error template results, updating type hints, and replacing direct time manipulation with FrozenDateTimeFactory usage.

  • Added parametrized tests to cover various state template scenarios
  • Updated test function signatures with explicit type hints
  • Replaced dt_util time changes with freezer.tick calls for more reliable time simulation
Comments suppressed due to low confidence (1)

tests/components/template/test_binary_sensor.py:276

  • The docstring in the 'test_state' function is misleading; update it to reflect that the test validates binary sensor state evaluation based on provided templates.
    """Test the config flow."""

@frenck frenck merged commit b8500b3 into dev Jun 27, 2025
34 checks passed
@frenck frenck deleted the epenet-20250627-1023 branch June 27, 2025 16:58
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@frenck frenck frenck approved these changes

Assignees

@Petro31 Petro31

Labels
cla-signed code-quality has-tests integration: template Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epenet @frenck @Petro31