Make jellyfin not single config entry #147656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @RunC0deRun, @ctalkington, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Jellyfin integration to allow multiple configuration entries by removing the single_config_entry restriction and updating related tests and fixtures.
- Drop
single_config_entryfrommanifest.jsonso multiple Jellyfin instances are supported - Remove the old single-instance abort test and add a new duplicate-entry abort test
- Update test fixture to use a more realistic user ID value
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/components/jellyfin/test_config_flow.py | Removed single-instance abort test; added test_already_configured to verify duplicate-entry abort behavior |
| tests/components/jellyfin/fixtures/get-user-settings.json | Changed "Id": "string" to "Id": "USER-UUID" for clarity in fixtures |
| homeassistant/components/jellyfin/manifest.json | Removed "single_config_entry": true to support multiple entries |
Comments suppressed due to low confidence (1)
tests/components/jellyfin/test_config_flow.py:193
- Consider adding a complementary test that verifies configuring a second Jellyfin instance with a different unique ID succeeds now that multiple entries are supported.
async def test_already_configured(
frenck
approved these changes
Jun 27, 2025
frenck
pushed a commit
that referenced
this pull request
Jun 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
jellyfin was set as "single config entry", although you can have multiple instances and the docs even talk about that case, and it already sets and checks a unique id. Fix that.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: