Respect availability of parent class in Husqvarna Automower #147649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the availability property in the Husqvarna Automower integration to ensure that the parent's availability status is respected.
- Changed the availability property in the button entity to incorporate the parent's available property
- Improves the overall evaluation of entity availability by combining both parent and entity-specific checks
Comments suppressed due to low confidence (1)
homeassistant/components/husqvarna_automower/button.py:93
- The change respects the parent's availability correctly; please ensure that the parent's 'available' property reliably returns a boolean value to prevent unintended behavior.
return super().available and self.entity_description.available_fn(
frenck
approved these changes
Jun 27, 2025
frenck
pushed a commit
that referenced
this pull request
Jun 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The parent class was not considered. With this, the properties get considered. Please include in next patch release.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: