Handle broadband_data being other types #147589
Draft
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have the full dev setup ready right now, so I'm unable to run the tests and only made the as a custom component in my regular HA system when trying the fix. |
frenck
requested changes
Jun 27, 2025
| return self.coordinator.data["broadband"]["isBroadbandConnected"] | ||
| broadband_data = self.coordinator.data.get("broadband") | ||
| if not broadband_data: | ||
| return False |
There was a problem hiding this comment.
Should this be False or None (unknown)?
There was a problem hiding this comment.
Not sure since I didn't manage to log the invalid data when it did happen.
Comment on lines
123
to
124
| broadband_data = self.coordinator.data.get("broadband") | ||
| if not broadband_data: |
There was a problem hiding this comment.
We can use a wallrus operator there.
| return False | ||
|
|
||
| # Handle case where broadband_data is a list | ||
| if isinstance(broadband_data, list): |
There was a problem hiding this comment.
This was a suggestion from my AI code editor, not sure, should I remove it?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I got this error randomly and it made Verisure auth expire for some reason. Couldn't reproduce it later, but this fix will hopefully handle the unexpected values better.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: