Skip to content

Do not make the favorite button unavailable when no content playing on a Music Assistant player #147579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

Do not make the favorite button unavailable when no content playing on a Music Assistant player #147579

merged 1 commit into from
Jun 26, 2025

Conversation

marcelveldt
Copy link
Member

Proposed change

When no content is playing we marked the "favorite current song" button as unavailable but this UX pattern was not particularly understood in the beta testing.

This PR changes this pattern so the button will stay available but raise an error if you press the button while it cant be executed,

Final solution should be implementing this FR: https://github.com/orgs/home-assistant/discussions/13

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @music-assistant, mind taking a look at this pull request as it has been labeled with an integration (music_assistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of music_assistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign music_assistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek joostlek added this to the 2025.7.0 milestone Jun 26, 2025
@marcelveldt marcelveldt changed the title Do not make the favorite button available when no content playing on a Music Assistant player Do not make the favorite button unavailable when no content playing on a Music Assistant player Jun 26, 2025
@marcelveldt marcelveldt merged commit d55ecd8 into dev Jun 26, 2025
34 checks passed
@marcelveldt marcelveldt deleted the mass-button-not-unavailable branch June 26, 2025 09:49
pelicarno pushed a commit to OlarmTech/home-assistant-core that referenced this pull request Jun 26, 2025
@marcelveldt @pelicarno
Do not make the favorite button unavailable when no content playing o…
2367236 
…n a Music Assistant player (home-assistant#147579)
frenck pushed a commit that referenced this pull request Jun 26, 2025
@marcelveldt @frenck
Do not make the favorite button unavailable when no content playing o…
153e1e4 
…n a Music Assistant player (#147579)
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed has-tests integration: music_assistant Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelveldt @joostlek @frenck