Add reconfiguration flow to PlayStation Network #147552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @JackJPowell, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
Adds a reconfiguration flow so users can update their NPSSO token without removing and re-adding the PlayStation Network integration.
- Implemented
async_step_reconfigureinconfig_flow.pyand wired it into the existing reauth logic - Added a test (
test_flow_reconfigure) for the new reconfigure path - Updated translations (
strings.json) and marked the rule as done inquality_scale.yaml
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/components/playstation_network/test_config_flow.py | Added test_flow_reconfigure to verify the reconfigure happy path |
| homeassistant/components/playstation_network/strings.json | Added UI text for the reconfigure step and new abort reason |
| homeassistant/components/playstation_network/quality_scale.yaml | Marked reconfiguration-flow as done |
| homeassistant/components/playstation_network/config_flow.py | Added async_step_reconfigure and adjusted async_step_reauth_confirm to handle reconfigure |
Comments suppressed due to low confidence (2)
tests/components/playstation_network/test_config_flow.py:301
- There’s a happy-path test for reconfiguration, but no coverage for an invalid NPSSO token. Add a test to verify the flow correctly surfaces authentication errors during reconfigure.
@pytest.mark.usefixtures("mock_psnawpapi")
homeassistant/components/playstation_network/config_flow.py:94
- The method
_get_reconfigure_entryisn't implemented, so reconfiguration will raise an AttributeError. Define_get_reconfigure_entry(analogous to_get_reauth_entry) or adjust the logic to use the existing entry method.
else self._get_reconfigure_entry()
frenck
approved these changes
Jun 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds reconfiguration support to PlayStation Network integration
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: