Skip to content

Add weekdays to time trigger #147505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add weekdays to time trigger #147505

wants to merge 2 commits into from

Conversation

frenck
Copy link
Member

@frenck frenck commented Jun 25, 2025 •
edited
Loading

Proposed change

As requested in: https://github.com/orgs/home-assistant/discussions/26

Adds a weekday option to the time triggers, allowing you to fire it only on certain days of the week.

image

automation:
  - triggers:
      - trigger: time
        at: "06:30:00"
        weekday:
          - "mon"
          - "tue"
          - "wed"
          - "thu"
          - "fri"
    actions:
      - action: script.morning_routine

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request: Add weekdays to time trigger frontend#25908

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homeassistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

This was referenced Jun 25, 2025
Open
Open
@frenck frenck marked this pull request as ready for review June 25, 2025 11:59
@frenck frenck requested a review from a team as a code owner June 25, 2025 11:59
abmantis
abmantis reviewed Jun 25, 2025
View reviewed changes
abmantis
abmantis reviewed Jun 25, 2025
View reviewed changes
tests/components/homeassistant/triggers/test_time.py
Comment on lines +890 to +897
monday_before_trigger = now.replace(
year=2023, month=1, day=2, hour=4, minute=59, second=0, microsecond=0
)
monday_trigger = now.replace(
year=2023, month=1, day=2, hour=5, minute=0, second=0, microsecond=0
)

freezer.move_to(monday_before_trigger)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
monday_before_trigger = now.replace(
year=2023, month=1, day=2, hour=4, minute=59, second=0, microsecond=0
)
monday_trigger = now.replace(
year=2023, month=1, day=2, hour=5, minute=0, second=0, microsecond=0
)
freezer.move_to(monday_before_trigger)
monday_trigger = now.replace(
year=2023, month=1, day=2, hour=5, minute=0, second=0, microsecond=0
)
freezer.move_to(monday_trigger)

I am not sure I understand why we have monday_before_trigger and monday_trigger, but then do monday_trigger + timedelta(seconds=1). Couldn't we just have monday_trigger?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, we could use the @pytest.mark.freeze_time("2023-01-02 05:00:00") decorator, and then just use now + timedeltas instead of now().replace() like tuesday_trigger = now + timedelta(days=1).

I think that would make the tests easier to read, but I am fine with either approache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abmantis abmantis abmantis left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
by-code-owner cla-signed core has-tests integration: homeassistant new-feature Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frenck @abmantis